Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup interfaces #1691

Merged
merged 26 commits into from
May 22, 2018
Merged

Cleanup interfaces #1691

merged 26 commits into from
May 22, 2018

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented May 17, 2018

This PR:

  • Deprecates the interfaces that ends with "2".
  • Moves all the methods of the 2 in the interfaces not numbered.
  • Deprecates obsolete members of old interfaces.

List of Interfaces purged:

  • Deprecate ICalibrateControl2 in favour of ICalibrateControl.
  • Deprecate ICalibrateControl2Raw in favour of ICalibrateControlRaw.
  • Deprecate IFrameGrabberControl2 in favour of IFrameGrabberControl.
  • Deprecate FrameGrabberControl2Impl in favour of FrameGrabberControlImpl
  • Deprecate IControlLimits2 in favour of IControlLimits.
  • Deprecate IControlLimits2Raw in favour of IControlLimitsRaw.
  • Deprecate ImplementControlLimits2 in favour of ImplementControlLimits.
  • Deprecate IControlMode2 in favour of IControlMode.
  • Deprecate IControlMode2Raw in favour of IControlModeRaw.
  • Deprecate ImplementControlMode2 in favour of ImplementControlMode.
  • Deprecate IPositionControl2Raw in favour of IPositionControlRaw.
  • Deprecate IPositionControl2 in favour of IPositionControl.
  • Deprecate ImplementPositionControl2 in favour of ImplementPositionControl.
  • Deprecate IVelocityControl2Raw in favour of IVelocityControlRaw.
  • Deprecate IVelocityControl2 in favour of IVelocityControl.
  • Deprecate ImplementVelocityControl2 in favour of ImplementVelocityControl.

Moreover it add the vocab VOCAB_FRAMEGRABBER_CONTROL_DC1934 for using the firewire interface.
To make yarp compiles extra changes have been done, and this PR probably breaks many things.

This PR has been tested on the iCubGenova01, it is ready to be merged

@Nicogene Nicogene added Component: Library - YARP_dev Component: Devices Type: Cleanup Involves cleaning up some part of YARP PR Status: Changelog - Not OK This PR does not have a changelog entry, or the changelog needs to be fixed PR Status: Test on Hardware - Not OK The code in this PR needs to be tested on the robot setup Type: Breaking/Behaviour Change Involves breaking user code or behaviour Target: YARP v3.0.0 labels May 17, 2018
@Nicogene Nicogene requested a review from traversaro as a code owner May 17, 2018 16:36
@Nicogene Nicogene force-pushed the cleanupInterfaces branch from fc54a6f to e904202 Compare May 18, 2018 12:52
@Nicogene Nicogene requested a review from aerydna as a code owner May 18, 2018 12:52
@Nicogene Nicogene force-pushed the cleanupInterfaces branch 3 times, most recently from 511e5e9 to 5c308d2 Compare May 21, 2018 07:43
Nicogene added a commit to Nicogene/icub-main that referenced this pull request May 21, 2018
Nicogene added a commit to Nicogene/icub-main that referenced this pull request May 21, 2018
Nicogene added a commit to Nicogene/icub-main that referenced this pull request May 21, 2018
Nicogene added a commit to Nicogene/icub-main that referenced this pull request May 21, 2018
@Nicogene Nicogene force-pushed the cleanupInterfaces branch from 3eec8cb to a299dec Compare May 21, 2018 16:07
@Nicogene Nicogene added PR Status: Changelog - OK This PR has a proper changelog entry and removed PR Status: Changelog - Not OK This PR does not have a changelog entry, or the changelog needs to be fixed labels May 21, 2018
Nicogene added 5 commits May 22, 2018 10:49
ICalibrateControl now contains the method of the old and new interface.
Moreover `calibrate2` has been deprecated in favour of `calibrate`,
`calibrate(int, double)` has been deprecated.
…rolRaw.

ICalibrateControlRaw now contains the method of the old and new interface.
Moreover `calibrate2Raw` has been deprecated in favour of `calibrateRaw`.
…ontrol.

IFrameGrabberControl now contains the method of the old and new interface.
Nicogene added a commit to Nicogene/icub-main that referenced this pull request May 22, 2018
@Nicogene Nicogene force-pushed the cleanupInterfaces branch from b9ab970 to fc375ee Compare May 22, 2018 13:03
@Nicogene Nicogene changed the title [WIP] Cleanup interfaces Cleanup interfaces May 22, 2018
@Nicogene Nicogene added PR Status: Test on Hardware - OK The code in this PR was successfully tested on the robot setup and removed PR Status: Test on Hardware - Not OK The code in this PR needs to be tested on the robot setup labels May 22, 2018
@drdanz drdanz merged commit 3285932 into robotology:devel May 22, 2018
@drdanz
Copy link
Member

drdanz commented May 22, 2018

Merged, thanks.

@Nicogene Nicogene deleted the cleanupInterfaces branch May 22, 2018 14:45
Nicogene added a commit to robotology/icub-main that referenced this pull request May 22, 2018
Nicogene added a commit to robotology/icub-main that referenced this pull request May 22, 2018
Nicogene added a commit to robotology/icub-main that referenced this pull request May 22, 2018
Nicogene added a commit to robotology/icub-main that referenced this pull request May 22, 2018
drdanz pushed a commit to drdanz/yarp that referenced this pull request Mar 29, 2019
drdanz pushed a commit to drdanz/yarp that referenced this pull request Apr 5, 2019
drdanz pushed a commit to drdanz/yarp that referenced this pull request Apr 8, 2019
@PeterBowman
Copy link
Member

I noticed that a lot of stuff in CBW2 could be removed after these changes: example. Not sure if you are already considering a cleanup of this device, @Nicogene.

drdanz pushed a commit to drdanz/yarp that referenced this pull request Apr 9, 2019
@Nicogene
Copy link
Member Author

I noticed that a lot of stuff in CBW2 could be removed after these changes: example. Not sure if you are already considering a cleanup of this device, @Nicogene.

Yes, the cleanup you pointed out should be done one day, honestly I don't know when 😅 .
If you want to open a PR, it is more than welcome 👍
This should be safe but in general the CBW is quite delicate to change it

@PeterBowman
Copy link
Member

If you want to open a PR, it is more than welcome +1

See #1999.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Devices Component: Library - YARP_dev PR Status: Changelog - OK This PR has a proper changelog entry PR Status: Test on Hardware - OK The code in this PR was successfully tested on the robot setup Resolution: Merged Target: YARP v3.0.0 Type: Breaking/Behaviour Change Involves breaking user code or behaviour Type: Cleanup Involves cleaning up some part of YARP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants