-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup interfaces #1691
Cleanup interfaces #1691
Conversation
fc54a6f
to
e904202
Compare
511e5e9
to
5c308d2
Compare
3eec8cb
to
a299dec
Compare
ICalibrateControl now contains the method of the old and new interface. Moreover `calibrate2` has been deprecated in favour of `calibrate`, `calibrate(int, double)` has been deprecated.
…rolRaw. ICalibrateControlRaw now contains the method of the old and new interface. Moreover `calibrate2Raw` has been deprecated in favour of `calibrateRaw`.
…ontrol. IFrameGrabberControl now contains the method of the old and new interface.
To be tested on icub-main
b9ab970
to
fc375ee
Compare
Merged, thanks. |
Yes, the cleanup you pointed out should be done one day, honestly I don't know when 😅 . |
See #1999. |
This PR:
List of Interfaces purged:
ICalibrateControl2
in favour ofICalibrateControl
.ICalibrateControl2Raw
in favour ofICalibrateControlRaw
.IFrameGrabberControl2
in favour ofIFrameGrabberControl.
FrameGrabberControl2Impl
in favour ofFrameGrabberControlImpl
IControlLimits2
in favour ofIControlLimits
.IControlLimits2Raw
in favour ofIControlLimitsRaw
.ImplementControlLimits2
in favour ofImplementControlLimits
.IControlMode2
in favour ofIControlMode
.IControlMode2Raw
in favour ofIControlModeRaw
.ImplementControlMode2
in favour ofImplementControlMode
.IPositionControl2Raw
in favour ofIPositionControlRaw
.IPositionControl2
in favour ofIPositionControl
.ImplementPositionControl2
in favour ofImplementPositionControl
.IVelocityControl2Raw
in favour ofIVelocityControlRaw
.IVelocityControl2
in favour ofIVelocityControl
.ImplementVelocityControl2
in favour ofImplementVelocityControl
.Moreover it add the vocab
VOCAB_FRAMEGRABBER_CONTROL_DC1934
for using the firewire interface.To make yarp compiles extra changes have been done, and this PR probably breaks many things.
This PR has been tested on the
iCubGenova01
, it is ready to be merged