Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update setup.sh for human-dynamics profile #257

Merged
merged 9 commits into from
Sep 19, 2019
Merged

Conversation

lrapetti
Copy link
Member

@lrapetti lrapetti commented Sep 19, 2019

The human-dynamics profile install the human-gazebo models, but the path to those models need to be add to YARP_DATA_DIRS in order to be found. For this reason I add this path in the setup.sh

@lrapetti lrapetti changed the title update setup.sh for human-dynamics profile [WIP]update setup.sh for human-dynamics profile Sep 19, 2019
@lrapetti lrapetti changed the title [WIP]update setup.sh for human-dynamics profile update setup.sh for human-dynamics profile Sep 19, 2019
@lrapetti
Copy link
Member Author

@kouroshD is there any other path that needs to be add for the human-dynamics profile?

@traversaro
Copy link
Member

This is exactly the reason why I would prefer if YARP_DATA_DIRS could be avoid to use, see robotology/yarp#336 , otherwise for each YARP "package" (i.e. something that installs in <prefix>/share) a new directory needs to be appended to YARP_DATA_DIRS.

However, this is not directly related to this PR. To finish the job, can you also:

Copy link
Member

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PR comments.

@lrapetti
Copy link
Member Author

To finish the job, can you also:

I think this was already handled with 9c6f139

83d217f

724228b

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -543,9 +542,13 @@ This profile is enabled by the `ROBOTOLOGY_ENABLE_HUMAN_DYNAMICS` CMake option.
### System Dependencies
To run a human dynamics estimation scenario, we need a Windows machine to install the Xsens suit SDK for getting the sensory information of the human motions from [Xsens](https://www.xsens.com/) and [ESD USB CAN driver](https://esd.eu/en/products/can-usb2) to get the FTShoes/FTSkShoes sensory information. Refer to [Xsens](#xsens) and [FTShoes/FTSkShoes](#shoes) for more information about the dependencies.

### Configuration
### System Dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the System Dependencies has been duplicated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, the information in this replicated System Dependencies previously were in the Configuration section (even if they refering to system dependency). I think we can remove that part.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed da2baa1

lrapetti and others added 3 commits September 19, 2019 15:06
Co-Authored-By: Silvio Traversaro <[email protected]>
Co-Authored-By: Silvio Traversaro <[email protected]>
@traversaro traversaro merged commit 78cf12b into master Sep 19, 2019
@traversaro
Copy link
Member

Thanks!

@lrapetti lrapetti deleted the lrapetti-patch-2 branch April 22, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants