Logging into the cluster does not refresh the tree

[adietish]

depends on redhat-developer/intellij-common#201

Steps:

1. ASSERT: make sure that you are not logged into your current cluster
2. EXEC: launch the plugin, unfold the root (cluster) node
3. ASSERT: tree shows "Please log into the cluster"
4. EXEC: pick "Log into the cluster" in the context menu and log in
5. ASSERT: dialog is closed, look at the tree

Result:
The tree still shows "Please log in to the cluster". "Refresh" doesnt help, I have to restart the IDE.

[martinszuc]

Earlier than Commits on Oct 5, 2023 for IJ Openshift: I used to remove /.kubo/config for a "logout" from cluster:

Nowadays after removing the kube config it just fails to load after refresh. (it doesnt default to the kubernetes.defuult link). The cluster link defaults itself only when I remove .kube/config WHILE THE PROJECT IS CLOSED!

As for logging in to the cluster, before Oct 5, it seemed to matter if I deleted whole .kube or just .kube/config file for logout before another login. With just the config file deleted, the login would default correctly in real time and next login would work correctly as well.
After Oct 5 this doesnt work and needs IDE restart for login.

Also closing and reopening the project seems to refresh the tree correctly just as restart.

Sooo i believe the change that affected this, was somewhere between Oct 5-6 and now. Wanted to share my findings.

[adietish]

Sooo i believe the change that affected this, was somewhere between Oct 5-6 and now. Wanted to share my findings.

@martinszuc thanks sharing. I'll try to fix your issue, too.

[adietish]

both use cases have different causes:

• removing the config file does not trigger a refresh of the tree because of a check in the ConfigWatcher. If the config is null, no update happens (config file was deleted, config is therefore null)

  @Override
    public void run() {
        runOnConfigChange((Config config) -> {
-->       if (config != null) {
                listener.onUpdate(this, config);
            }
        });
    }

This check was introduced because of redhat-developer/intellij-common#190

• changing the config (update the token) triggers a refresh but other flaws caused the update to fail.

[adietish]

to fix this I created redhat-developer/intellij-common#201