Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigWatcher is triggering multiple events for a single modification of a file #190

Closed
adietish opened this issue Jul 25, 2023 · 4 comments · Fixed by #192
Closed

ConfigWatcher is triggering multiple events for a single modification of a file #190

adietish opened this issue Jul 25, 2023 · 4 comments · Fixed by #192
Assignees
@adietish
Labels
severity/major

Comments

@adietish
Copy link
Contributor

See redhat-developer/intellij-kubernetes#640 for more details on this. It seems to be a know defect on Linux/Windows.
@adietish adietish mentioned this issue Jul 25, 2023
Closed
@adietish
Copy link
Contributor Author

adietish commented Jul 25, 2023 •
edited
Loading

@datho7561 found out that the sequence of events come in 3 cases:

@datho7561:
here are three cases:

  • 1st event: the file is empty, 2nd event: then complete
  • 1st event: the file is incomplete, 2nd event: then complete
  • 1st event: the file is complete, 2nd event: then complete (again)

@adietish
Copy link
Contributor Author

adietish commented Jul 25, 2023 •
edited
Loading

We therefore think that we need to prevent events from be propagated where the kube config file does not exist, is empty or is not valid yaml (incomplete file)

datho7561 added a commit to datho7561/intellij-common that referenced this issue Jul 25, 2023
@datho7561
Ignore kubeconfig changes where the config file is empty or deleted
51fadfe 
I'm not convinced this is doing much to address
redhat-developer/intellij-kubernetes#640.
In practice, the first few times I attempt to switch namespaces,
the tree collapses, regardless of if I use this PR or the existing code.
After that, I can occasionally switch namespaces without the tree
collapsing.

See redhat-developer#190.

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 mentioned this issue Jul 25, 2023
Closed
@adietish
Copy link
Contributor Author

@datho7561: @olkornii is back ready to test things. I'll therefore make sure we have a fix that he can test.

adietish added a commit to adietish/intellij-common that referenced this issue Jul 26, 2023
@adietish
only notify change when kube config exists, isnt empty and complete (r…
60e5a7e 
…edhat-developer#190)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-common that referenced this issue Jul 26, 2023
@adietish
only notify change when kube config exists, isnt empty and complete (r…
1403c31 
…edhat-developer#190)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-common that referenced this issue Jul 26, 2023
@adietish
only notify change when kube config exists, isnt empty and complete (r…
e48c8a8 
…edhat-developer#190)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-common that referenced this issue Jul 26, 2023
@adietish
fix: only notify change when kube config exists, isnt empty and compl…
1092f6c 
…ete (redhat-developer#190)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit that referenced this issue Jul 26, 2023
@adietish
fix: only notify change when kube config exists, isnt empty and compl…
de3e6eb 
…ete (#190) (#192)

Signed-off-by: Andre Dietisheim <[email protected]>
@adietish adietish mentioned this issue Jul 26, 2023
Merged
@adietish adietish self-assigned this Jul 26, 2023
@adietish
Copy link
Contributor Author

#192 was merged. Closing.

@adietish adietish mentioned this issue Jul 26, 2023
Merged
This was referenced Nov 13, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adietish adietish

Labels
severity/major
Projects
None yet
Milestone
No milestone
1 participant
@adietish