Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigWatcher does not notify if kubeconfig was deleted #201

Closed
adietish opened this issue Nov 13, 2023 · 1 comment · Fixed by #202
Closed

ConfigWatcher does not notify if kubeconfig was deleted #201

adietish opened this issue Nov 13, 2023 · 1 comment · Fixed by #202
Assignees
@adietish
Milestone
1.9.3

Comments

@adietish
Copy link
Contributor

this follows up on #190

In #190 a check was introduced that would prevent multiple events from making it to the client program. Unfortunately this then caused - and we didn't notice it - removals of the kubeconfig not to be notified.
Removing this check means that client programs now need to take care of the multiple events (for the same change) that #190 aimed at preventing.
@adietish adietish self-assigned this Nov 13, 2023
adietish added a commit to adietish/intellij-common that referenced this issue Nov 13, 2023
@adietish
fix: allow to compare client- and fileconfig-contexts (redhat-develop…
07d9ad5 
…er#201)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-common that referenced this issue Nov 13, 2023
@adietish
fix: allow to compare fileconfig-contexts (redhat-developer#201)
5914aa0 
Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-common that referenced this issue Nov 13, 2023
@adietish
fix: allow to compare fileconfig-contexts (redhat-developer#201)
223f523 
Signed-off-by: Andre Dietisheim <[email protected]>
This was referenced Nov 13, 2023
Closed
Merged
@adietish
Copy link
Contributor Author

@sbouchet: this PR makes sure that the config watcher would notify if the kubeconfig is removed and then offers the methods to compare a new kubeconfig with the old one, making sure things are null-safe (current impl in intellij-openshift isn't)

@adietish adietish moved this to 🏗 In progress in IDE Cloudaptors Nov 13, 2023
adietish added a commit to adietish/intellij-common that referenced this issue Nov 13, 2023
@adietish
fix: allow to compare fileconfig-contexts (redhat-developer#201)
59f46a8 
Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-common that referenced this issue Nov 13, 2023
@adietish
fix: allow to compare fileconfig-contexts (redhat-developer#201)
14e87e6 
Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-common that referenced this issue Nov 13, 2023
@adietish
fix: notify if config file was deleted (redhat-developer#201)
fe04954 
Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-common that referenced this issue Nov 13, 2023
@adietish
fix: allow to compare fileconfig-contexts (redhat-developer#201)
d512960 
Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit that referenced this issue Nov 14, 2023
@adietish
fix: notify if config file was deleted (#201)
02ecc7f 
Signed-off-by: Andre Dietisheim <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in IDE Cloudaptors Nov 14, 2023
adietish added a commit that referenced this issue Nov 14, 2023
@adietish
fix: allow to compare fileconfig-contexts (#201)
fef9547 
Signed-off-by: Andre Dietisheim <[email protected]>
@adietish adietish added this to the 1.9.3 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adietish adietish

Labels
None yet
Projects
IDE Cloudaptors
Archived in project
Milestone
1.9.3
1 participant
@adietish