-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: notify if config file was deleted, allow to compare fileconfig-contexts (#201) #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adietish
changed the title
fix: allow to compare client- and fileconfig-contexts (#201)
fix: notify if config file was deleted, allow to compare client- and fileconfig-contexts (#201)
Nov 13, 2023
adietish
changed the title
fix: notify if config file was deleted, allow to compare client- and fileconfig-contexts (#201)
fix: notify if config file was deleted, allow to compare fileconfig-contexts (#201)
Nov 13, 2023
adietish
force-pushed
the
issue-201
branch
2 times, most recently
from
November 13, 2023 21:15
59f46a8
to
14e87e6
Compare
Signed-off-by: Andre Dietisheim <[email protected]>
Signed-off-by: Andre Dietisheim <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
adietish
added a commit
to adietish/intellij-kubernetes
that referenced
this pull request
Nov 14, 2023
this change is required by the change in ConfigWatcher at redhat-developer/intellij-common#202 Signed-off-by: Andre Dietisheim <[email protected]>
sbouchet
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
adietish
added a commit
to adietish/intellij-kubernetes
that referenced
this pull request
Nov 15, 2023
this change is required by the change in ConfigWatcher at redhat-developer/intellij-common#202 Signed-off-by: Andre Dietisheim <[email protected]>
adietish
added a commit
to adietish/intellij-kubernetes
that referenced
this pull request
Nov 15, 2023
this change is required by the change in ConfigWatcher at redhat-developer/intellij-common#202 Signed-off-by: Andre Dietisheim <[email protected]>
adietish
added a commit
to adietish/intellij-kubernetes
that referenced
this pull request
Nov 20, 2023
this change is required by the change in ConfigWatcher at redhat-developer/intellij-common#202 Signed-off-by: Andre Dietisheim <[email protected]>
adietish
added a commit
to adietish/intellij-kubernetes
that referenced
this pull request
Nov 20, 2023
this change is required by the change in ConfigWatcher at redhat-developer/intellij-common#202 Signed-off-by: Andre Dietisheim <[email protected]>
adietish
added a commit
to adietish/intellij-kubernetes
that referenced
this pull request
Nov 20, 2023
this change is required by the change in ConfigWatcher at redhat-developer/intellij-common#202 Signed-off-by: Andre Dietisheim <[email protected]>
adietish
added a commit
to redhat-developer/intellij-kubernetes
that referenced
this pull request
Nov 22, 2023
this change is required by the change in ConfigWatcher at redhat-developer/intellij-common#202 Signed-off-by: Andre Dietisheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #201