Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notify if config file was deleted, allow to compare fileconfig-contexts (#201) #202

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Nov 13, 2023

fixes #201

@adietish adietish self-assigned this Nov 13, 2023
@adietish adietish requested a review from sbouchet November 13, 2023 16:03
@adietish adietish marked this pull request as draft November 13, 2023 16:10
@adietish adietish removed the request for review from sbouchet November 13, 2023 16:10
@adietish adietish requested a review from sbouchet November 13, 2023 18:06
@adietish adietish marked this pull request as ready for review November 13, 2023 18:07
@adietish adietish changed the title fix: allow to compare client- and fileconfig-contexts (#201) fix: notify if config file was deleted, allow to compare client- and fileconfig-contexts (#201) Nov 13, 2023
@adietish adietish changed the title fix: notify if config file was deleted, allow to compare client- and fileconfig-contexts (#201) fix: notify if config file was deleted, allow to compare fileconfig-contexts (#201) Nov 13, 2023
@adietish adietish force-pushed the issue-201 branch 2 times, most recently from 59f46a8 to 14e87e6 Compare November 13, 2023 21:15
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

adietish added a commit to adietish/intellij-kubernetes that referenced this pull request Nov 14, 2023
this change is required by the change in ConfigWatcher at
redhat-developer/intellij-common#202

Signed-off-by: Andre Dietisheim <[email protected]>
Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adietish adietish merged commit fef9547 into redhat-developer:main Nov 14, 2023
15 checks passed
@adietish adietish deleted the issue-201 branch November 14, 2023 14:30
adietish added a commit to adietish/intellij-kubernetes that referenced this pull request Nov 15, 2023
this change is required by the change in ConfigWatcher at
redhat-developer/intellij-common#202

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-kubernetes that referenced this pull request Nov 15, 2023
this change is required by the change in ConfigWatcher at
redhat-developer/intellij-common#202

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-kubernetes that referenced this pull request Nov 20, 2023
this change is required by the change in ConfigWatcher at
redhat-developer/intellij-common#202

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-kubernetes that referenced this pull request Nov 20, 2023
this change is required by the change in ConfigWatcher at
redhat-developer/intellij-common#202

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-kubernetes that referenced this pull request Nov 20, 2023
this change is required by the change in ConfigWatcher at
redhat-developer/intellij-common#202

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to redhat-developer/intellij-kubernetes that referenced this pull request Nov 22, 2023
this change is required by the change in ConfigWatcher at
redhat-developer/intellij-common#202

Signed-off-by: Andre Dietisheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ConfigWatcher does not notify if kubeconfig was deleted
2 participants