-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refreshing tree upon config change or kubeconfig removal (#595) #610
Conversation
Skipping CI for Draft Pull Request. |
2c035ef
to
c8243c8
Compare
@sbouchet: This is ready for review as soon as redhat-developer/intellij-common#202 is merged and published. |
412d6cf
to
39f9310
Compare
@adietish : for the two uses cases it works well. But i got an issue when i switch clusters on kubernetes view. see the screencast look at when i switch cluster, i got error on helm charts. |
@sbouchet: can you please verify the following:
when switching from cluster 1 to cluster 2, the current namespace displayed in the resource tree still is the current namespace that was set in cluster 1. |
@sbouchet: The error where the helm charts could not be fetched any more went away for me once I depended on intellij-kubernetes 1.2.0.271. Can you please verify? |
Signed-off-by: Andre Dietisheim <[email protected]>
d91f0aa
to
21e3d19
Compare
/override ci/prow/e2e-4.11 |
@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-4.11 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
baaa4ee
to
931ce1a
Compare
src/it/java/org/jboss/tools/intellij/openshift/utils/odo/OdoCliTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jboss/tools/intellij/openshift/tree/application/BaseNode.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please review comments
…eloper#621) Signed-off-by: Andre Dietisheim <[email protected]>
fixed your complaints. Please re-review. |
SonarCloud Quality Gate failed. 0 Bugs 0.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
@adietish: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed with local minikube and devsandbox. LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbouchet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/e2e-4.11 |
@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/e2e-openshift |
@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
depends on redhat-developer/intellij-common#202
fixes #595
fixes #621