Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refreshing tree upon config change or kubeconfig removal (#595) #610

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Nov 8, 2023

Copy link

openshift-ci bot commented Nov 8, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@adietish adietish self-assigned this Nov 8, 2023
@adietish adietish force-pushed the issue-595 branch 8 times, most recently from 2c035ef to c8243c8 Compare November 14, 2023 10:40
@adietish adietish changed the title fix: fixed refreshing tree upon config change fix: fixed refreshing tree upon config change (#595) Nov 14, 2023
@adietish adietish changed the title fix: fixed refreshing tree upon config change (#595) fix: fixed refreshing tree upon config change or kubeconfig removal (#595) Nov 14, 2023
@adietish
Copy link
Contributor Author

@sbouchet: This is ready for review as soon as redhat-developer/intellij-common#202 is merged and published.
It makes sure that the tree is refreshed as soon as there's a change in config or that the kube config was removed (and also when it reappears)

@adietish adietish marked this pull request as ready for review November 14, 2023 15:34
@openshift-ci openshift-ci bot requested a review from sbouchet November 14, 2023 15:35
@adietish adietish force-pushed the issue-595 branch 4 times, most recently from 412d6cf to 39f9310 Compare November 16, 2023 09:48
@sbouchet
Copy link
Collaborator

@adietish : for the two uses cases it works well.
1- after loging to devsandbox
2 - after removal of kube config file.

But i got an issue when i switch clusters on kubernetes view. see the screencast
Capture vidéo du 2023-11-16 16-32-16.webm

look at when i switch cluster, i got error on helm charts.
trying another time, i can see clusters again, but on openshift i got default cluster name ( kubernetes.default.svc )

@redhat-developer redhat-developer deleted a comment from openshift-ci bot Nov 17, 2023
@redhat-developer redhat-developer deleted a comment from openshift-ci bot Nov 17, 2023
@redhat-developer redhat-developer deleted a comment from openshift-ci bot Nov 17, 2023
@adietish
Copy link
Contributor Author

adietish commented Nov 17, 2023

@sbouchet: can you please verify the following:
When you face the case where the current namespace that is displayed in openshift tooling is wrong, do you have a current namespace set?
In the cases where I can replicate your problem statement, I had the the following setup:

  • cluster 1: sandbox, current namespace set
  • cluster 2: minikube, no current namespace set

when switching from cluster 1 to cluster 2, the current namespace displayed in the resource tree still is the current namespace that was set in cluster 1.
Wondering if you can confirm this. Thanks.

@adietish
Copy link
Contributor Author

@sbouchet: The error where the helm charts could not be fetched any more went away for me once I depended on intellij-kubernetes 1.2.0.271. Can you please verify?

@adietish adietish force-pushed the issue-595 branch 2 times, most recently from d91f0aa to 21e3d19 Compare November 24, 2023 11:38
@adietish
Copy link
Contributor Author

/override ci/prow/e2e-4.11

Copy link

openshift-ci bot commented Nov 24, 2023

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adietish adietish force-pushed the issue-595 branch 2 times, most recently from baaa4ee to 931ce1a Compare November 24, 2023 13:33
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review comments

@adietish
Copy link
Contributor Author

please review comments

fixed your complaints. Please re-review.

@adietish adietish requested a review from sbouchet November 24, 2023 14:13
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

openshift-ci bot commented Nov 24, 2023

@adietish: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-4.11 931ce1a link true /test e2e-4.11

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed with local minikube and devsandbox. LGTM

Copy link

openshift-ci bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbouchet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbouchet
Copy link
Collaborator

/override ci/prow/e2e-4.11

Copy link

openshift-ci bot commented Nov 24, 2023

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbouchet
Copy link
Collaborator

/override ci/prow/e2e-openshift

Copy link

openshift-ci bot commented Nov 24, 2023

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbouchet sbouchet merged commit d9e585b into redhat-developer:main Nov 24, 2023
11 of 12 checks passed
@adietish adietish deleted the issue-595 branch November 24, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If my cluster is not reachable I get a "Fatal IDE error" Logging into the cluster does not refresh the tree
2 participants