Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add babel module tagging #301

Merged
merged 2 commits into from
Jun 29, 2016
Merged

Conversation

doug-wade
Copy link
Collaborator

@doug-wade doug-wade commented Jun 22, 2016

Continue the breakup of #280 . Includes #294, #297 and #300

@doug-wade doug-wade force-pushed the add-babel-module-tagging branch from d9ae70e to be2be2a Compare June 22, 2016 22:33
@gigabo gigabo added the enhancement New functionality. label Jun 24, 2016
@doug-wade doug-wade force-pushed the add-babel-module-tagging branch 2 times, most recently from a2b313f to a1edf06 Compare June 24, 2016 21:37
@doug-wade doug-wade force-pushed the add-babel-module-tagging branch from a1edf06 to 4b4b400 Compare June 24, 2016 21:46
const config = { trim: state.opts.trim };
const parent = path.resolve(path.join(process.cwd(), '..')) + path.sep;
const fp = this.file.opts.filename.replace(parent, '');
const file = { path: fp };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, a nicer interface for the module tagger would eliminate the need for this nonsense.

@doug-wade doug-wade merged commit d961c9f into redfin:master Jun 29, 2016
davidalber pushed a commit to davidalber/react-server that referenced this pull request Jul 24, 2016
* Add api and cli for module tagging

* Add module tagging babel plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants