Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve react-server-module-tagger interface #314

Closed
doug-wade opened this issue Jun 29, 2016 · 1 comment
Closed

Improve react-server-module-tagger interface #314

doug-wade opened this issue Jun 29, 2016 · 1 comment

Comments

@doug-wade
Copy link
Collaborator

In #301 and #302, I factored out a common module from react-server-gulp-module tagger that has some pretty rough remnants of its past as a gulp module. We should clean up the interface to be more appropriate to the new api.
@doug-wade doug-wade mentioned this issue Jun 30, 2016
Closed
@doug-wade doug-wade mentioned this issue Aug 15, 2016
Merged
doug-wade added a commit to doug-wade/react-server that referenced this issue Aug 15, 2016
@doug-wade
redfin#314 Clean up react-server-module-tagger interface
4d91cfc
doug-wade added a commit to doug-wade/react-server that referenced this issue Aug 15, 2016
@doug-wade
redfin#314 Clean up react-server-module-tagger interface
626dcd2
doug-wade added a commit that referenced this issue Aug 15, 2016
@doug-wade
Merge pull request #560 from doug-wade/fix-314
e337848 
#314 Pass parameters to module tagger explicitly, rather than in function context
@doug-wade
Copy link
Collaborator Author

This was resolved in 98a9577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@doug-wade