Add babel plugin for module tagging #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-wade
force-pushed
the
add-babel-plugin
branch
from
3e3f806 to
a1fac00
Compare
|
|
* Upgrade lerna-2.0.0-beta.18 This picks up some patches that will help us out: - lerna/lerna#181 - lerna/lerna#196 - lerna/lerna#198 - lerna/lerna#199 * Use `lerna clean` for `npm run nuke`
Previously ClientController's nodeArrival function just took in the node index, but this made it such that each arriving node required its own script tag and LABjs callback; now nodeArrival can take in a range of indices to minimize overhead.
Porting the changes from the main README to the react-server README
Reduce nodeArrival calls by taking in range of node indices
Adds babel-plugin-react-server to the react-server-cli webpack loader and babel-preset-react-server. Factor out react-server-module-tagger from react-server-gulp-module-tagger to share module tagging format between gulp and babel, and add tests to ensure prevent regressions.
doug-wade
force-pushed
the
add-babel-plugin
branch
from
a1fac00 to
42347a9
Compare
This was referenced Jun 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add babel-plugin-react-server to the react-server-cli webpack loader and
babel-preset-react-server. Factor out react-server-module-tagger from
react-server-gulp-module-tagger to share module tagging format between
gulp and babel, and add tests to ensure prevent regressions. As discussed in #276; fixes #12 and #247