Add gulp module tagger tests #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-wade
force-pushed
the
add-gulp-module-tagger-tasks
branch
3 times, most recently
from
6444e4c to
5addc33
Compare
doug-wade
force-pushed
the
add-gulp-module-tagger-tasks
branch
3 times, most recently
from
9a1e27c to
26c4104
Compare
| @@ -5,7 +5,7 @@ | |||
| "main": "target/index.js", | |||
| "scripts": { | |||
| "prepublish": "gulp", | |||
| "test": "gulp test && nsp check", | |||
There was a problem hiding this comment.
Despite many hours trying to resolve nsp advisories, I'm disabling it because its broken only on travis (the error looks like https://travis-ci.org/redfin/react-server/builds/139052220). I've filed a ticket with nodesecurity.io.
doug-wade
force-pushed
the
add-gulp-module-tagger-tasks
branch
2 times, most recently
from
b5ea07f to
455c9da
Compare
doug-wade
force-pushed
the
add-gulp-module-tagger-tasks
branch
4 times, most recently
from
93b7fc0 to
ecb86ef
Compare
doug-wade
force-pushed
the
add-gulp-module-tagger-tasks
branch
from
ecb86ef to
820aea4
Compare
This was referenced Jun 21, 2016
|
+1 |
| @@ -15,3 +15,6 @@ addons: | |||
|
|
|||
| before_script: | |||
| - npm run bootstrap | |||
|
|
|||
| after_failure: | |||
| - npm run debug | |||
|
This is sweet. Thanks @doug-wade! |
davidalber
pushed a commit
to davidalber/react-server
that referenced
this pull request
Jul 24, 2016
* Cat npm-debug.logs on failure * Add gulp module tagger tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#280 is getting too big for me to handle, so I'm breaking it up into smaller prs. Add regression tests to prevent errors while refactoring gulp-module-tagger. Includes #297