ci(GHA): drop actions/setup-node
#476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out my `ghcr.io/catthehacker/ubuntu` image was out-of-date, so I was using a different version of Node locally than what was actually running on GitHub 🤦 This updates our contributing guidelines to call this out (mostly for myself)
kanadgupta
added
documentation
ademidoff
suggested changes
Mar 10, 2022
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16 | ||
| # When we add debug support, we should make this a conditional step, see RM-3545 |
There was a problem hiding this comment.
This comment may still be useful I guess
Co-authored-by: Alex Tymchuk <[email protected]>
erunion
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
The only reason we have the
setup-nodestep in the action is because I was under the impression thatubuntu-latestwas running Node v14/npm@6 and I didn't want that to mess with ourpackage-lock.json, which islockfileVersion@2.Turns out I was completely wrong and
ubuntu-latesthas been on Node 16 for several months now: https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.mdI realized this was because my local
actrunner image was out-of-date, so this PR also updates our contributing docs to call that out.🧬 QA & Testing
Do tests pass and do the docs look good?
As an extra sanity check, I confirmed that
ubuntu-latestis running Node v16 in 5f675fb. You can see the results here: https://github.com/readmeio/rdme/runs/5498116121?check_suite_focus=true#step:4:8