Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(GHA): drop actions/setup-node #476

Merged
merged 6 commits into from
Mar 10, 2022
Merged

ci(GHA): drop actions/setup-node #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5f675fb
chore(GHA): drop setup-node step
kanadgupta Mar 10, 2022
1c9862e
docs: update contributing guidelines
kanadgupta Mar 10, 2022
21a780a
revert(kinda): remove all debugging, drop setup-node step
kanadgupta Mar 10, 2022
0496788
chore: remove comment
kanadgupta Mar 10, 2022
a48aec7
docs: use CLI command instead
kanadgupta Mar 10, 2022
6e1f59b
Update CONTRIBUTING.md
erunion Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ Once you've installed `act`, it'll ask you what Docker image size you'd like. Th
-P ubuntu-18.04=ghcr.io/catthehacker/ubuntu:act-18.04
```

Our GitHub Actions guidance states that Action workflows should have a [`runs-on` value](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on) of `ubuntu-latest`. These runners are updated frequently — you can find links to the the latest versions by navigating [here](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#preinstalled-software) and selecting the latest Ubuntu link. Because of this, you'll want to make sure your `ghcr.io/catthehacker/ubuntu` image stays up-to-date by doing a periodic pull:

```sh
docker pull ghcr.io/catthehacker/ubuntu:act-latest
```

Once it's configured, you can use the `-l` flag to to view all the workflows:

```sh
Expand Down
6 changes: 0 additions & 6 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@ inputs:
runs:
using: composite
steps:
# This is so we can guarantee a version of npm that supports lockfile@2
- name: setup node
uses: actions/setup-node@v3
with:
node-version: 16
# When we add debug support, we should make this a conditional step, see RM-3545
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment may still be useful I guess

- name: Install rdme deps
run: npm install --production --silent
shell: bash
Expand Down