ci(GHA): drop actions/setup-node (#476)

* chore(GHA): drop setup-node step

* docs: update contributing guidelines

Turns out my `ghcr.io/catthehacker/ubuntu` image was out-of-date, so I was using a different version of Node locally than what was actually running on GitHub 🤦

This updates our contributing guidelines to call this out (mostly for myself)

* revert(kinda): remove all debugging, drop setup-node step

* chore: remove comment

* docs: use CLI command instead

* Update CONTRIBUTING.md

Co-authored-by: Alex Tymchuk <[email protected]>

Co-authored-by: Jon Ursenbach <[email protected]>
Co-authored-by: Alex Tymchuk <[email protected]>

CONTRIBUTING.md

@@ -33,6 +33,12 @@ Once you've installed `act`, it'll ask you what Docker image size you'd like. Th
 -P ubuntu-18.04=ghcr.io/catthehacker/ubuntu:act-18.04
 ```
 
+Our GitHub Actions guidance states that Action workflows should have a [`runs-on` value](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on) of `ubuntu-latest`. These runners are updated frequently — you can find links to the the latest versions by navigating [here](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#preinstalled-software) and selecting the latest Ubuntu link. Because of this, you'll want to make sure your `ghcr.io/catthehacker/ubuntu` image stays up-to-date by doing a periodic pull:
+
+```sh
+docker pull ghcr.io/catthehacker/ubuntu:act-latest
+```
+
 Once it's configured, you can use the `-l` flag to to view all the workflows:
 
 ```sh

action.yml

@@ -11,12 +11,6 @@ inputs:
 runs:
   using: composite
   steps:
-    # This is so we can guarantee a version of npm that supports lockfile@2
-    - name: setup node
-      uses: actions/setup-node@v3
-      with:
-        node-version: 16
-    # When we add debug support, we should make this a conditional step, see RM-3545
     - name: Install rdme deps
       run: npm install --production --silent
       shell: bash