Do not require to run actions/setup-node

[ademidoff]

Hey,

This is to make you aware that some of your customers may have disabled running actions other than those cloned to their own organization. In our use case, for security reasons we consider all third-party actions to be unsafe, therefore we clone an action we need to run in our GITHUB CI environment, which allows us to only run a select number of actions.

Therefore, in our case it's impossible to run readmeio/rdme since it depends on setup-node, so we see this error message:

Error: Bad request - actions/setup-node@v2 is not allowed to be used in <company_name>. Actions in this
workflow must be within a repository owned by <company_name> or match the following: actions/setup-node@v2.

The solution may be quite trivial: given that both NodeJS and npm are provisioned by default, you hardly even need to run that action.

Will you consider not using any third-party actions please?

[kanadgupta]

Hi @atymchuk!

To provide a bit of background on why we originally did this: we wanted to guarantee that the runner was using a version of Node.js that supported our package-lock.json, which is lockfileVersion@2 (i.e. Node v16+).

I did some digging this morning and it appears that ubuntu-latest has been shipping with Node v16 for some time now 🎉

I've opened up #476, which removes the actions/setup-node step from our workflow.

Thanks for calling this out!

-Kanad

[ademidoff]

@kanadgupta This is a big win for folks like us, we appreciate it very much!