-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 19 #1657
Merged
Merged
Release 19 #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* discount skeleton - remove from core - add core/discounts - add discounts-rates - add discount-codes - new discount schemas [WIP] * local module import of translations - adds `loadTranslations` and `loadTranslation` methods - removes necessity to add translations to core - `import { loadTranslations } from "/server/startup/i18n”;` - multiple file import illustrated in reaction-taxes - single import illustrated in reaction-discounts - introduces mergeDeep helper in i18n/startup and updates to translation resource structure to accommodate additional namespaces for package (uses package name). * updated i18n namespace and handling - add i18n handling for griddle column headers - add local i18n imports to discounts - updated i18n taxSettings namespace (into packages + admin) * change info logging to debug * schemas, forms, ui, i18n for discount modules * updated Discount schemas - implement client collections for DiscountCodes, DiscountRates - implement multi-schema on server Discounts collection * updated discounts pub - split security out * Meteor 1.4.2.1 updated to Meteor 1.4.2.1. * group payments packages - resolves #1408 - consolidates all payment packages into a single admin group - rename include payment package folders `payment-` - add initial local i18n, moved from en.json (TODO, other lang). - move “default method” setting from shop to new `core/payments` package. - move checkout/payment templates from core to `core/payments` package. - expose icon in public registry
* Build product detail page from JS object * Allow for nested blocks, custom styling. Removed old code. Added default columns of 12 if block columns not specified. * Fix responsive image issues in media gallery * Fix pdp add to cart button styles * ReactionLayout for react Moved layout generator to "layout" core module. Added permission check for top level blocks. * Permissions for components in React ReactionLayout renderer * Pass ProductDetail props to component in layout tree. * Style updates for product detail page configuration. * Remove logger, as it doesn't provide useful data in its current form * Adds ability to add react template layout to database to render full page views * Adds ability to use media queries when defining blocks * add missing dependency for radium * fix broken template tests
* added some comments to break up html table * reorganized data for email template removed all [0]. type variables from new.html email template, so all variables are set in orders.js for easy manipulation * welcome to the shop email template * extract social from template, add on/off switch * invite shop member email * shopName variable updates * update reaction address This was driving me crazy seeing the wrong address in all these emails being tested. * add Collections imports for Accounts, Cart, Shopts * password reset emails * update subject of order confirmation email * lint fix * renamed file for email template * removed test text * path file organization * mail -> SMTP for clarification * Merge branch 'release-0.18.0' into email-template-expansion-v2 # Conflicts: # imports/plugins/included/email-templates/lib/paths.js * i18n for email template admin * publication for Templates * conflict fix * add email subject into saved DB data * add server methods for deleting email templates * Add a duplicate, editable template to the template collection (#1548) Mark one of those templates and an original, which can be used to revert editable templates. * server methods for updating email templates * added check for original template * new translations * Merge branch 'release-0.18.0' into email-template-expansion-v2 * core workflow emails - processing & completed * test - new workflow email exports * Update email schema * shipping email * conflict fixes * removed comments * removed comments * import new email schema * template updates * removed commented code * organize templates * added todo to schema * updated comments * cleanup methods file * updated error messaging * schema update * update comments * i18n updates * removed testing alerts * i18n updates * file organization
* Add media hook. Rename file to "hooks'" * Only return published images for non-admin users * Only set product images as unpublished * Capture revision record and show Publish button when image changes are made * Adding images deferred until published * Removing images deferred until published * Capturing and deferring other changes to metadata (priority really) * Combine revisions when making multiple changes before publishing * Properly handle non-product revisions in applyProductRevision so that product doesn't get wiped. * Find the product correctly based on revision type * Fix regression where images weren't being published because revision data was wrong * Setting priceRange should be in an `else` statement * If you add an image and then delete it before publishing it, just remove it. * Update revisions with media * Show visual indicator on image if there are pending revisions * Discard drafts of image revisions * Sometimes rendering the "edited" marker * Reset revisions so that removals take effect * Set priority to revision priority * Fix issue where changing order wouldn't stick * Remove logging * Change lost in merge * Another change from merge
* Green flash on fields in PDP page after change success * Updated tags and metafields with a flash of green on success submit
Removed duplicate Templates publication
* updated tests for discount methods * updated meteor versions - includes update johanbrook:publication-collector
PDP admin panel now has expandable cards with selecting fields to edit from PDP page.
* change templates importing to use Assets collection * renamed templates function * fixed listing errors * add flush & changed onCoreInit -> afterCoreInit * removed isOriginalTemplate, which is no longer used * InitTemplates() -> initTemplates()
- moved “Import” from settings/settings.html to import/import.html - is currently not used and won’t be visible, but can be basis for import settings. resolves #1050
* update workflow when process is not done the traditional way * update import order * fixed linting issues * removed old / unused nom packages
Sort dashboard apps by priority
* remove text and VerticalDivider from Toolbar * update @warn number field width * fixes double line on pages without revision control buttons
- Added TabList and TabItem components
* Tweak UIX of action view - Add overlay for action view - Use velocity for slide animation of action view - Fix for completely hidden action view at phone breakpoint - Move close button to left for action view - master view * Update UI for action view - Fixing various issues with responsiveness - Added animations and overlays * Style tweaks for dashboard - Fixing dual borders on panels in panel groups for package list - Improve enter / leave animation for action view - detail view
- Add hover and active states to list items - Add arrow to each list item - Improve layout and style of size selector
* auto enable edit mode for first time admin logins * update to make "admin" mode default, if you haven't turned it off. * removed unused field
* moved accounts registry into new core package * LingoHub Update 🚀 Manual push by LingoHub User: Aaron Judd. Project: reaction Made with ❤️ by https://lingohub.com * LingoHub Update 🚀 Manual push by LingoHub User: Aaron Judd. Project: reaction Made with ❤️ by https://lingohub.com * Updated translation imports
* LESS updates for PDP media gallery * split into featured media and thumbnails * pass props down to mediaGallery * always return featured media as true * always allow featuredMediaOnHover * add react-measure * update less * add react-measure * pull image measurements from mediaGallery * fix sizing issue on admin featuredImage * fix error when removing unpublished media * add key to Measure to fix error
* Prevent product deletion from creating revisions for archived products Prevent instances where archiving a product would also archive products that are already archived, resulting in more revision documents being created when not necessary. * Prevent variant deletion from creating revisions for archived products * Prevent broken ancestors during archived product restoration - Prevent a child variant from being restored if its parent variant is still marked as `isDeleted` (archived). * - Import Tags collection to fix errors on product create * Prevent child variants from being added to a deleted parent variant * Add default label for variant so it doesn't look broken when new. * Update error messaging for add top variant * Don't allow a product to be cloned if its parent is deleted * Updated translations and comments * Adjust import order * Shorten i18n text * Fix alert display when archiving products
* Added ability to publish all items on product grid When no items are selected on the product grid, the publish controls in the toolbar defaults to publishing all changes to all products on the grid. * Update product grid display - Add overlay to products when they are not visible - Add indicator when products have changes - Sort product grid after revision data is applied * Removed sort and limit from product find * Simplify product positions update. Simplify update for product positions to prevent cases where updating the size and then position will cause products to be rendered in incorrect positions or sizes.
* Remove deprecated avalara package * Replace npm package * Add new fields * Use new internal module * Implement new TaxRate API * Get and save company code * Submittting cart to Avalara (not working yet) * Adding JSDOc and debug * Succesfully submitting cart to TaxRate API * Use TaxRate API for cart calcularions * Eliminate files for unused Avalara API * Capturing orders for SalesInvoice * Properly recording orders * Recording returns * Work around "duplicate transaction" error. * Record refunds * Fix typo/eslint/JSDoc issues * Add Geocoding package * Add Geocoding package * Geocoding is for chumps * Run unit tests in CI * Add Meteor method for discoverability * Pull up the proper geocoding function and call it * Convert method to synchronous * Use latest version of library * Lengthen timeout * simple "pass/fail" validation via geocoding * Add USPS zipcode verification library * Add zipcode validation to addAccount * Fix country code fix * Fix validation results * Make refunds committed * Remove zipcode validation * Remove zipcode package * Use Avalara validation if enabled * Destructure and restructure address to Avalara format * Compare addresses item by item * Show message when addresses don't match * Substitute validated address for entered address, show warning. * Set dropdown values * Have "edit" addressbook also validate address * When no address validators are enabled, skip it * When no address validators are enabled, skip it * Remove providerName key * Change method of registering addressValidation methods based on Aaron's feedback * Add enable/disable address validation * Handle validation messages from validator when it has additional things to say about address * Remove generic geocoding plugin * Changes to edit form as well * Handles cases where address validation is not supported for this country * Fix issue with Avalara trying to calc tax when it's not enabled. * Only pass in taxrate if it's defined and is a number * Reenable all tests * Protect against being passed in an undefined order * Fixing tests * Trying to fix tests * Remove running unit test * Up the timeout on the discounts test * Fix issue with "Expected the after hook to return a value" message * removed "form-control" class
* fix close button not showing in FireFox * fix search modal display
* put grid alerts into same container * fix spacing for visibility indicator
* Use a direct import instead of a Meteor method and remove security check * moved inventory adjustment into payment approval
mikemurray
approved these changes
Feb 15, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App runs and can checkout. All other issues can be hammered out when merged to development.
* Added import for Meteor Accounts package. - Also prevent Accounts (meteor) from colliding with Accounts (reaction collection) * Updated import order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 19 will concentrate on UI / UIX bug fixes and enhancements.
Major Features
https://waffle.io/reactioncommerce/reaction?milestone=v0.19.0
Other Features
imports/plugins/
now have a localserver/i18n
directory for translations.Other Changes / Fixes
0.19.0
Contributors
@reactioncommerce/core
@lcampanis
@prosf
@chluke123
@f3rnando