Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some i18n mapping fixes #1708

Closed
ch-lukas opened this issue Jan 11, 2017 · 1 comment · Fixed by #1851
Closed

Some i18n mapping fixes #1708

ch-lukas opened this issue Jan 11, 2017 · 1 comment · Fixed by #1851
Assignees
Milestone

Comments

@ch-lukas
Copy link
Contributor

ch-lukas commented Jan 11, 2017

Two that I have found so far:

  1. In "notificationDropdown.js" it refers to "notifications.body.noNotifcations" but should be "notifications.body.noNotifications"

  2. "availableOptions" should be under "productDetail" and not shop

@aaronjudd
Copy link
Contributor

i18n also needs to move into import/plugins/include/notifications/server/i18n as well (the i18n doesn't need to be in the private/data/i18n.

@aaronjudd aaronjudd self-assigned this Jan 17, 2017
@aaronjudd aaronjudd added ready and removed ready labels Jan 17, 2017
@aaronjudd aaronjudd added this to the v0.19.0 milestone Jan 17, 2017
@kieckhafer kieckhafer mentioned this issue Feb 1, 2017
@ghost ghost assigned mikemurray Feb 3, 2017
@ghost ghost added review and removed in progress labels Feb 3, 2017
@ghost ghost removed the review label Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants