Fix Product Not Found infinite spinner #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemurray
requested changes
Jan 17, 2017
| <TranslationProvider> | ||
| <div className="container-fluid-sm"> | ||
| <div className="empty-view-message"> | ||
| <i className="fa fa-barcode"></i> |
There was a problem hiding this comment.
must self close if empty <i className="fa fa-barcode" />
mikemurray
approved these changes
Jan 17, 2017
brent-hoover
requested changes
Jan 18, 2017
| import { SocialContainer, VariantListContainer } from "./"; | ||
| import { MediaGalleryContainer } from "/imports/plugins/core/ui/client/containers"; | ||
| import { DragDropProvider, TranslationProvider } from "/imports/plugins/core/ui/client/providers"; | ||
| import { StyleRoot } from "radium"; | ||
| import { isEmpty } from "lodash"; |
There was a problem hiding this comment.
Shouldn't this import go first?
brent-hoover
approved these changes
Jan 18, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1630
PDP was displaying an infinite spinner if there was no product at the URL. This fix converts our old Product Not Found page to a React Component and displays when it should.