Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1708 notifications i18n typo #1765

Merged
merged 3 commits into from
Feb 1, 2017
Merged

1708 notifications i18n typo #1765

merged 3 commits into from
Feb 1, 2017

Conversation

f3rnando
Copy link
Contributor

@f3rnando f3rnando commented Jan 31, 2017 •
edited
Loading

Are you submitting to development?

We currently only accept PR's to development not master

  • Description explains the issue / use-case resolved
  • Only contains code directly related to the issue
  • Has tests.
  • Has docs.
  • Passes all tests
  • Has been linted and follows the style guide

Aaron Judd and others added 2 commits January 16, 2017 20:44
Merge pull request reactioncommerce#1720 from reactioncommerce/develo…
7dfaa8d 
…pment

Release 0.18.1
Update notificationDropdown.js
f3bea53 
notifications.body.noNotifications for notifications.body.noNotifcations
@CLAassistant
Copy link

CLAassistant commented Jan 31, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@aaronjudd aaronjudd merged commit 071f600 into reactioncommerce:development Feb 1, 2017
@aaronjudd aaronjudd removed the ready label Feb 1, 2017
@kieckhafer kieckhafer mentioned this pull request Feb 1, 2017
Merged
@mikemurray mikemurray mentioned this pull request Feb 16, 2017
Merged
@kieckhafer kieckhafer mentioned this pull request Feb 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronjudd aaronjudd aaronjudd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f3rnando @CLAassistant @aaronjudd