-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnexpecTEDIntentPolicy
final merge
#8913
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rasa into e2e-feature-combining-layers-2.2
Co-authored-by: Johannes E. M. Mosig <[email protected]>
Co-authored-by: Johannes E. M. Mosig <[email protected]>
JEM-Mosig
approved these changes
Jul 12, 2021
* Draft _collect_action_executed_predictions * Update to correctly run predictions when using `rasa test` * action_executed_eval_store.add_to_store * Updated format for stories * Reformatting and bugifx * formatter * fix some tests. 1 remaining * more tests * fix remaining test * restructure it a bit * formatting and hardcoded strings removed * WarningPredictedAction * Code style fix * Code style updates * Fixes and `test_action_unlikely_intent_fail_on_prediction_errors` * Formatting * Code style & test updates * fix tests and code formatting Co-authored-by: Daksh <[email protected]>
wochinge
suggested changes
Jul 12, 2021
Gitleaks still complains about the commits that push secrets to |
wochinge
reviewed
Jul 12, 2021
wochinge
approved these changes
Jul 12, 2021
@HotThoughts it's just a fake config and no real credentials |
Fix here 😊. The gitleaks should pass now. Update: Oh no. Gitleaks still complains about it. Let me check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
This PR introduces a new policy called
UnexpecTEDIntentPolicy
and accompanying functionality for different rasa commands likerasa train
,rasa test
, etc.Note: The whole feature development was broken down into smaller PRs which were independently reviewed. No code was directly committed to this branch without being peer reviewed as part of a PR.
To get a better understanding of the feature implementation, please head over to the implementation document.
All the smaller PRs are listed below -
Completed PRs
Research:
IntentMaxHistoryTrackerFeaturizer
MultiLabelDotProductLoss
IntentTEDPolicy
ranking_length
Engineering:
action_unlikely_intent
actionIntentTEDPolicy
to default configurationIntentTEDPolicy
:rasa test
updates #8843 andIntentTEDPolicy
: Updatedrasa test
tests #8949rasa data validate
to warn ifaction_unlikely_intent
is present in story training data.Note: The introduction of a new default action will make the overall release breaking backwards compatibility of models.
This has been communicated in the changelog and migration guide
Status (please check what you already did):
black
(please check Readme for instructions)