Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnexpecTEDIntentPolicy final merge #8913

Merged
merged 360 commits into from
Jul 12, 2021
Merged

UnexpecTEDIntentPolicy final merge #8913

merged 360 commits into from
Jul 12, 2021

Conversation

dakshvar22
Copy link
Contributor

@dakshvar22 dakshvar22 commented Jun 17, 2021

Proposed changes:

This PR introduces a new policy called UnexpecTEDIntentPolicy and accompanying functionality for different rasa commands like rasa train, rasa test, etc.

Note: The whole feature development was broken down into smaller PRs which were independently reviewed. No code was directly committed to this branch without being peer reviewed as part of a PR.

To get a better understanding of the feature implementation, please head over to the implementation document.

All the smaller PRs are listed below -

Completed PRs

Research:

Engineering:

Note: The introduction of a new default action will make the overall release breaking backwards compatibility of models.
This has been communicated in the changelog and migration guide

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

samsucik and others added 30 commits March 22, 2021 09:47
dakshvar22 and others added 2 commits July 12, 2021 10:50
Co-authored-by: Johannes E. M. Mosig <[email protected]>
Co-authored-by: Johannes E. M. Mosig <[email protected]>
@JEM-Mosig JEM-Mosig self-requested a review July 12, 2021 09:05
@dakshvar22 dakshvar22 requested a review from wochinge July 12, 2021 12:14
* Draft _collect_action_executed_predictions

* Update to correctly run predictions when using `rasa test`

* action_executed_eval_store.add_to_store

* Updated format for stories

* Reformatting and bugifx

* formatter

* fix some tests. 1 remaining

* more tests

* fix remaining test

* restructure it a bit

* formatting and hardcoded strings removed

* WarningPredictedAction

* Code style fix

* Code style updates

* Fixes and `test_action_unlikely_intent_fail_on_prediction_errors`

* Formatting

* Code style & test updates

* fix tests and code formatting

Co-authored-by: Daksh <[email protected]>
rasa/core/policies/ted_policy.py Outdated Show resolved Hide resolved
tests/utils/test_train_utils.py Show resolved Hide resolved
@HotThoughts
Copy link
Contributor

Gitleaks still complains about the commits that push secrets to rasa/data/test_moodbot/credentials.yml . Is it intentional to keep those secrets in the code? If yes, one thing that we can do is to tell gitleaks ignore this file.

@dakshvar22 dakshvar22 requested a review from wochinge July 12, 2021 12:52
@dakshvar22 dakshvar22 requested a review from wochinge July 12, 2021 12:56
@wochinge
Copy link
Contributor

@HotThoughts it's just a fake config and no real credentials

@HotThoughts
Copy link
Contributor

HotThoughts commented Jul 12, 2021

Fix here 😊. The gitleaks should pass now.

Update: Oh no. Gitleaks still complains about it. Let me check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants