-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break up rasa.core.featurizers.tracker_featurizers into separate modules. #9056
Comments
Exalate commented: samsucik commented: I think this one is actually blocked by #8798 because the tracker featuriser tests are a mess right now and it makes no sense to split them into featuriser-specific files before they're in a good shape as such. Definition of done (once #8798 is done) could be:
|
Exalate commented: JEM-Mosig commented: This might become redundant if the disentangling spike yields a plan that we want to go through with. |
Exalate commented: stale[bot] commented: This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description of Problem: It was suggested that that
rasa/core/featurizers/tracker_featurizers.py
is now quite large with the addition ofIntentMaxHistoryTrackerFeaturizer
and that this module should be broken into smaller modules (see this comment), possibly for each class:TrackerFeaturizer
,FullDialogueTrackerFeaturizer
,MaxHistoryTrackerFeaturizer
, andIntentMaxHistoryTrackerFeaturizer
.In doing so one should also split the corresponding tests in
tests/core/featurizers/test_tracker_featurizers.py
. Additionally,rasa/core/featurizers/tracker_featurizers/__init__.py
should be created which imports all tracker featurizers into therasa.core.featurizers.tracker_featurizers
namespace so that this logic for loading a serialized tracker featurizer is not broken.The text was updated successfully, but these errors were encountered: