Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break up rasa.core.featurizers.tracker_featurizers into separate modules. #9056

Closed
kedz opened this issue Jul 6, 2021 · 3 comments
Closed
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework feature:ml/intent-ted

Comments

@kedz
Copy link
Contributor

kedz commented Jul 6, 2021

Description of Problem: It was suggested that that rasa/core/featurizers/tracker_featurizers.py is now quite large with the addition of IntentMaxHistoryTrackerFeaturizer and that this module should be broken into smaller modules (see this comment), possibly for each class: TrackerFeaturizer, FullDialogueTrackerFeaturizer, MaxHistoryTrackerFeaturizer, and IntentMaxHistoryTrackerFeaturizer.

In doing so one should also split the corresponding tests in tests/core/featurizers/test_tracker_featurizers.py. Additionally, rasa/core/featurizers/tracker_featurizers/__init__.py should be created which imports all tracker featurizers into the rasa.core.featurizers.tracker_featurizers namespace so that this logic for loading a serialized tracker featurizer is not broken.

@kedz kedz added area:rasa-oss 🎡 Anything related to the open source Rasa framework feature:ml/intent-ted labels Jul 6, 2021
@samsucik
Copy link
Contributor

samsucik commented Jul 9, 2021

Exalate commented:

samsucik commented:

I think this one is actually blocked by #8798 because the tracker featuriser tests are a mess right now and it makes no sense to split them into featuriser-specific files before they're in a good shape as such.

Definition of done (once #8798 is done) could be:

  1. Broke down tracker_featurizers.py into separate modules
  2. Added __init__.py to exposes all featurisers and verified that get_featurizer_from_dict works with all
  3. Split tests into separate files while ensuring as little code duplication as possible and also ensuring that coverage doesn't decrease for any individual featuriser

@JEM-Mosig
Copy link
Contributor

JEM-Mosig commented Jul 9, 2021

Exalate commented:

JEM-Mosig commented:

This might become redundant if the disentangling spike yields a plan that we want to go through with.

@stale
Copy link

stale bot commented Jan 9, 2022

Exalate commented:

stale[bot] commented:

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 9, 2022
@TyDunn TyDunn removed the stale label Jan 27, 2022
@rasabot-exalate rasabot-exalate added area:rasa-oss and removed area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Mar 15, 2022 — with Exalate Issue Sync
@rasabot rasabot added area:rasa-oss 🎡 Anything related to the open source Rasa framework and removed area:rasa-oss labels Mar 16, 2022
@rasabot-exalate rasabot-exalate added area:rasa-oss area:rasa-oss 🎡 Anything related to the open source Rasa framework and removed area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss labels Mar 17, 2022 — with Exalate Issue Sync
@m-vdb m-vdb closed this as completed Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework feature:ml/intent-ted
Projects
None yet
Development

No branches or pull requests

7 participants