Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntentTEDPolicy: Updated rasa test tests #8949

Merged
merged 5 commits into from
Jun 25, 2021
Merged

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Jun 24, 2021

Proposed changes:

  • do monkey patching inside rasa test tests because every time the tests are run, training will result in different model weights which will result in different predictions of action_unlikely_intent.
  • update the imports inside rasa.cli.test

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@alwx alwx changed the base branch from main to intent-ted June 24, 2021 12:55
@alwx alwx requested a review from wochinge June 24, 2021 12:57
@alwx alwx marked this pull request as ready for review June 24, 2021 12:57
@alwx alwx changed the title Updated tests for IntentTEDPolicy IntentTEDPolicy: Updated rasa test tests Jun 24, 2021
rasa/cli/test.py Outdated Show resolved Hide resolved
tests/core/test_test.py Outdated Show resolved Hide resolved
tests/core/test_test.py Outdated Show resolved Hide resolved
@alwx alwx requested a review from wochinge June 25, 2021 10:28
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@alwx alwx merged commit 05d0df1 into intent-ted Jun 25, 2021
@alwx alwx deleted the intent-ted-patched-tests branch June 25, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants