Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IntentTEDPolicy to the default configuration. #8748

Merged
merged 6 commits into from
Jun 15, 2021
Merged

Add IntentTEDPolicy to the default configuration. #8748

merged 6 commits into from
Jun 15, 2021

Conversation

alwx
Copy link
Contributor

@alwx alwx commented May 26, 2021 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@alwx alwx changed the title Intent ted policy default Add IntentTEDPolicy to the default configuration. May 26, 2021
@alwx alwx force-pushed the intent-ted-policy-default branch from 859650e to 25bfebd Compare June 9, 2021 14:32
@alwx alwx requested review from ancalita and joejuzl June 9, 2021 14:33
@alwx alwx marked this pull request as ready for review June 9, 2021 14:33
@alwx alwx requested a review from a team as a code owner June 9, 2021 14:33
@alwx alwx requested a review from wochinge June 11, 2021 09:21
@alwx alwx removed request for joejuzl and ancalita June 11, 2021 09:22
wochinge
wochinge suggested changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's missing from rasa.shared.importers.default_config.yml, isn't it?

@alwx alwx requested a review from wochinge June 15, 2021 11:07
wochinge
wochinge approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you double check the policy's default params with Daksh/Chris? Looks good to me otherwise 👍🏻

@alwx alwx merged commit 7979891 into intent-ted Jun 15, 2021
@alwx alwx deleted the intent-ted-policy-default branch June 15, 2021 11:50
@dakshvar22 dakshvar22 mentioned this pull request Jun 29, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakshvar22 dakshvar22 dakshvar22 left review comments

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alwx @wochinge @dakshvar22