IntentTEDPolicy: rasa interactive updates
#8906
Conversation
|
There are literally no tests for |
alwx
force-pushed
the
rasa-interactive-intent-ted
branch
from
441cb4f to
c2e13b6
Compare
| ) | ||
| monkeypatch.setattr(interactive, "_form_is_rejected", Mock(return_value=False)) | ||
| monkeypatch.setattr(interactive, "_form_is_restored", Mock(return_value=False)) | ||
| monkeypatch.setattr(interactive, "send_action", asyncio.coroutine(Mock())) |
There was a problem hiding this comment.
how about making sure this gets called with the expected values?
| f"to indicate that the last user message was unexpected " | ||
| f"at this point in the conversation. " | ||
| f"Check out IntentTEDPolicy ({DOCS_URL_POLICIES}/#intent-ted-policy) " | ||
| f"to learn more." |
There was a problem hiding this comment.
Do we need to ask the user here to press Y/N to continue?
There was a problem hiding this comment.
That's what we've decided to do, yes (to keep it consistent with the rest)
There was a problem hiding this comment.
Ah ok, then maybe it should be explicitly stated? Unless questionary takes care of this 😄
There was a problem hiding this comment.
IMO this should instead be written in docs with the explanation what action_unlikely_intent is and how it works. We can also write it here but I am afraid the message will be too long in this case.
There was a problem hiding this comment.
Ah I meant maybe it's not obvious what keys to press from the question and that should be explicitly stated, thats all 👍
There was a problem hiding this comment.
Oh, got it! Actually, questionary handles that and shows the available options automatically :)
| is_correct = await _ask_questions(question, conversation_id, endpoint) | ||
| is_correct = ( | ||
| await _ask_questions(question, conversation_id, endpoint) | ||
| or action_name == ACTION_UNLIKELY_INTENT_NAME |
There was a problem hiding this comment.
Does this line imply that regardless of user answer to the query, the action is always correct for action_unlikely_intent?
There was a problem hiding this comment.
It means that the choice (Y/N) doesn't affect what's gonna be happening next.
Proposed changes:
rasa interactivetoIntentTEDPolicy(action_unlikely_intent)rasa interactive#8421It requires
rasa testupdates to be merged first! #8843Status (please check what you already did):
black(please check Readme for instructions)