Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move package config to an interface #39295

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Mar 8, 2024

  • Change PackageConfig to an interface
  • Move JAR-specific configuration to JarConfig group
  • Replace package type with combination of JAR type and JAR/native enable flags
  • Introduce compatibility interceptors for complex remappings
  • Update all build steps, tests, and POMs to use the new properties

@quarkus-bot quarkus-bot bot added area/amazon-lambda area/cli Related to quarkus cli (not maven/gradle/etc.) area/config area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/funqy area/google-cloud-functions area/gradle Gradle area/jbang Issues related to when using jbang.dev with Quarkus area/kotlin area/kubernetes area/maven area/panache area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/resteasy-classic area/scala area/security area/spring Issues relating to the Spring integration area/testing labels Mar 8, 2024
Copy link

quarkus-bot bot commented Mar 8, 2024

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@dmlloyd
Copy link
Member Author

dmlloyd commented Mar 11, 2024

This must stay in draft until SmallRye Config is released with smallrye/smallrye-config#1128.

This comment has been minimized.

dmlloyd added a commit to dmlloyd/quarkus that referenced this pull request Mar 26, 2024
This functionality was mistakenly removed in quarkusio#39295.

Fixes quarkusio#39669.
dmlloyd added a commit to dmlloyd/quarkus that referenced this pull request Apr 25, 2024
dmlloyd added a commit to dmlloyd/quarkus that referenced this pull request Apr 29, 2024
gsmet added a commit to gsmet/quarkus-updates that referenced this pull request Apr 29, 2024
ketola pushed a commit to ketola/quarkus that referenced this pull request May 1, 2024
This functionality was mistakenly removed in quarkusio#39295.

Fixes quarkusio#39669.
@edeandrea
Copy link
Contributor

FYI I don't think the templates on code.quarkus.io were updated to accomodate some of these changes. When I create a project from code.quarkus.io it still generates <quarkus.package.type>native</quarkus.package.type> in the native profile...

dmlloyd added a commit to dmlloyd/code.quarkus.io that referenced this pull request May 7, 2024
ia3andy pushed a commit to quarkusio/code.quarkus.io that referenced this pull request May 7, 2024
gsmet pushed a commit to gsmet/quarkus that referenced this pull request May 10, 2024
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this pull request Jul 31, 2024
dmlloyd added a commit to dmlloyd/quarkus that referenced this pull request Nov 14, 2024
bschuhmann pushed a commit to bschuhmann/quarkus that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/amazon-lambda area/cli Related to quarkus cli (not maven/gradle/etc.) area/config area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/funqy area/google-cloud-functions area/gradle Gradle area/jbang Issues related to when using jbang.dev with Quarkus area/kotlin area/kubernetes area/maven area/panache area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/resteasy-classic area/scala area/security area/spring Issues relating to the Spring integration area/testing release/noteworthy-feature triage/flaky-test
Projects
Development

Successfully merging this pull request may close these issues.

6 participants