-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix daily / CI failures by bumping the Test Framework to 1.4.2.Beta9 and migrating package type configuration property #1723
Fix daily / CI failures by bumping the Test Framework to 1.4.2.Beta9 and migrating package type configuration property #1723
Conversation
run tests |
@gtroitsk OCP JVM failures are not related because OTel condition seems to fail as test is badly written (I'll provide fix in a separate PR) and Infinispan I can't see related to changes listed in the quarkus-qe/quarkus-test-framework#1069. |
Ah, there is a difference in the traces after all, but it's not related. Will need to look it up. |
Found it, caused by quarkusio/quarkus#39534. I'll open new PR. |
@michalvavrik can you analyse please what caused failures in |
The question is, how is it relevant to the changes here? There is so many failures I need to fix, this is not on the top of my list. I run I plan to debug it tomorrow and open upstream issue over class cast exception. |
In that case it is ok, thank you for testing and confirmation. I will merge this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@@ -151,7 +151,7 @@ Be sure that GraalVM is installed by running the following command, otherwise yo | |||
User: `Deploy in OpenShift the module http-minimum compiled with my local GraalVM in order to build my application` | |||
|
|||
```shell | |||
mvn clean verify -Popenshift -Dall-modules -Dquarkus.package.type=native -pl http/http-minimum | |||
mvn clean verify -Popenshift -Dall-modules -Dquarkus.package.jar.type=native -pl http/http-minimum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is wrong, fast-jar,legacy-jar,uber-jar,mutable-jar
should be the allowed only ones @michalvavrik
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, luckily it's just a README, I'll create a fix.
Summary
As a follow up of the quarkusio/quarkus#39295 we should adapt our tests. While fallback config interceptors are in place, we need to sync properties set with how the framework detects them and works with them.
Please select the relevant options.
run tests
phrase in comment)Checklist: