Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote DEV tests after breaking package config changes #1070

Merged

Conversation

michalvavrik
Copy link
Member

Summary

Remote DEV mode tests running with Quarkus 999-SNAPSHOT are failing after quarkusio/quarkus#39295 got merged. One example can be https://github.com/quarkus-qe/quarkus-test-suite/actions/runs/8374170247/job/22929729333. Quarkus introduced fallback config interceptors, however we also need to detect it correctly, which seems to be a problem. This PR does:

  • disables DEV mode tests in native as there is no point to run them there
  • sets new properties and keep the old ones for compatibility as FW is also run with released version

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from gtroitsk March 21, 2024 22:49
@michalvavrik
Copy link
Member Author

Windows failure is fixed here #1074.

@michalvavrik michalvavrik mentioned this pull request Mar 21, 2024
11 tasks
pom.xml Show resolved Hide resolved
@michalvavrik michalvavrik force-pushed the feature/fix-remote-dev-tests-in-native branch from 86930ff to 5ad4ad6 Compare March 22, 2024 10:51
@michalvavrik
Copy link
Member Author

@gtroitsk CI is green :-)

@gtroitsk gtroitsk merged commit 2f62bd0 into quarkus-qe:main Mar 22, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/fix-remote-dev-tests-in-native branch March 22, 2024 12:55
@michalvavrik michalvavrik mentioned this pull request Apr 23, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants