Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bat43 Keyboard #8648

Merged
merged 10 commits into from
Apr 5, 2020
Merged

Add bat43 Keyboard #8648

merged 10 commits into from
Apr 5, 2020

Conversation

yfuku
Copy link
Contributor

@yfuku yfuku commented Apr 1, 2020 •
edited
Loading

Description

add bat43 keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Only complaint I have is the presence of the LAYOUT_kc macro. In general, we highly discourage the use of it, as it causes issues, especially for newer users.

And since it appears to not be in use, could it be completely removed?

@drashna drashna requested a review from a team April 2, 2020 07:31
@yfuku
Copy link
Contributor Author

yfuku commented Apr 2, 2020

@drashna
Thanks for reviewing it.
I have removed LAYOUT_kc.

noroadsleft
noroadsleft requested changes Apr 4, 2020
View reviewed changes
keyboards/bat43/bat43.c Outdated Show resolved Hide resolved
keyboards/bat43/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/bat43/readme.md Outdated Show resolved Hide resolved
keyboards/bat43/rules.mk Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Apr 4, 2020
View reviewed changes
keyboards/bat43/bat43.h Outdated Show resolved Hide resolved
fauxpark
fauxpark reviewed Apr 4, 2020
View reviewed changes
keyboards/bat43/bat43.h Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team April 4, 2020 06:26
noroadsleft
noroadsleft approved these changes Apr 5, 2020
View reviewed changes
keyboards/bat43/bat43.h
Comment on lines +31 to +46
#define LAYOUT( \
k00, k01, k02, k03, k04, k05, k40, k41, k42, k43, k44, k45, \
k10, k11, k12, k13, k14, k15, k30, k50, k51, k52, k53, k54, k55, \
k20, k21, k22, k23, k24, k25, k60, k61, k62, k63, k64, k65, \
k33, k34, k35, k70, k71, k72, \
k74, k75, k73, k31, k32 \
) { \
{ k00, k01, k02, k03, k04, k05 }, \
{ k10, k11, k12, k13, k14, k15 }, \
{ k20, k21, k22, k23, k24, k25 }, \
{ k30, k31, k32, k33, k34, k35 }, \
{ k40, k41, k42, k43, k44, k45 }, \
{ k50, k51, k52, k53, k54, k55 }, \
{ k60, k61, k62, k63, k64, k65 }, \
{ k70, k71, k72, k73, k74, k75 }, \
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@noroadsleft noroadsleft merged commit 120fcc5 into qmk:master Apr 5, 2020
@noroadsleft
Copy link
Member

Thanks!

@yfuku
Copy link
Contributor Author

yfuku commented Apr 5, 2020

Thank you!

HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Apr 10, 2020
@yfuku @HokieGeek
[Keyboard] Add bat43 Keyboard (qmk#8648)
8e23b7b 
* carete bat43 dir by new_keyboard.sh

* customize

* bugfix

* fix

* remove LAYOUT_kc

* Update keyboards/bat43/readme.md

* Update keyboards/bat43/rules.mk

* Remove unnecessary parts

* converted to Kxy format

* Update keyboards/bat43/bat43.h
Quarren42 pushed a commit to Quarren42/qmk_firmware that referenced this pull request Apr 15, 2020
@yfuku @Quarren42
[Keyboard] Add bat43 Keyboard (qmk#8648)
6664f4f 
* carete bat43 dir by new_keyboard.sh

* customize

* bugfix

* fix

* remove LAYOUT_kc

* Update keyboards/bat43/readme.md

* Update keyboards/bat43/rules.mk

* Remove unnecessary parts

* converted to Kxy format

* Update keyboards/bat43/bat43.h
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@yfuku @kujawakk
[Keyboard] Add bat43 Keyboard (qmk#8648)
e5e95d0 
* carete bat43 dir by new_keyboard.sh

* customize

* bugfix

* fix

* remove LAYOUT_kc

* Update keyboards/bat43/readme.md

* Update keyboards/bat43/rules.mk

* Remove unnecessary parts

* converted to Kxy format

* Update keyboards/bat43/bat43.h
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@yfuku @lorenzoernesto
[Keyboard] Add bat43 Keyboard (qmk#8648)
064da28 
* carete bat43 dir by new_keyboard.sh

* customize

* bugfix

* fix

* remove LAYOUT_kc

* Update keyboards/bat43/readme.md

* Update keyboards/bat43/rules.mk

* Remove unnecessary parts

* converted to Kxy format

* Update keyboards/bat43/bat43.h
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@yfuku @sowbug
[Keyboard] Add bat43 Keyboard (qmk#8648)
5c0118d 
* carete bat43 dir by new_keyboard.sh

* customize

* bugfix

* fix

* remove LAYOUT_kc

* Update keyboards/bat43/readme.md

* Update keyboards/bat43/rules.mk

* Remove unnecessary parts

* converted to Kxy format

* Update keyboards/bat43/bat43.h
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Jun 11, 2020
Merge remote-tracking branch 'upstream/master'
851f7c2 
* upstream/master: (312 commits)
  updated rules.mk and default keymap of Wonderland for VIA support (qmk#8668)
  Added Caps Lock LED handler to wilba.tech PCBs (qmk#8660)
  Add keyboard TGR-910 (qmk#8683)
  V-USB remote wakeup (qmk#7627)
  Add Greek keymap (qmk#8636)
  Add Polish keymap (qmk#8637)
  Add Korean keymap (qmk#8635)
  [Keyboard] Add 60_hhkb layout to hhkb (qmk#8618)
  [Keyboard] romeo - add via layout (qmk#8667)
  [Keyboard] Add ReverseStudio-DecadePad (qmk#8553)
  [Keyboard] Add bat43 Keyboard (qmk#8648)
  minor tweaks
  Fix saving output from avrdude and dfu-programmer
  Use version_arg in ESSENTIAL_BINARIES dict
  Fixes qmk#8541 by getting version from -dumpversion then --version as fallback
  VIA Support: 1upkeyboards Sweet16 (qmk#8652)
  [Keyboard] Lattice60 (qmk#8603)
  Discipline - Add ISO compatibility, rawHID enable, via layout (qmk#8627)
  [Keyboard] Add Orbit-X Keyboard (qmk#8605)
  add 60_tsangan_hhkb layout to GH60 rev. C (qmk#8617)
  ...
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@yfuku @jakobaa
[Keyboard] Add bat43 Keyboard (qmk#8648)
a6fe420 
* carete bat43 dir by new_keyboard.sh

* customize

* bugfix

* fix

* remove LAYOUT_kc

* Update keyboards/bat43/readme.md

* Update keyboards/bat43/rules.mk

* Remove unnecessary parts

* converted to Kxy format

* Update keyboards/bat43/bat43.h
thorstenweber83 pushed a commit to thorstenweber83/qmk_firmware that referenced this pull request Sep 2, 2020
@yfuku @thorstenweber83
[Keyboard] Add bat43 Keyboard (qmk#8648)
d7a17e1 
* carete bat43 dir by new_keyboard.sh

* customize

* bugfix

* fix

* remove LAYOUT_kc

* Update keyboards/bat43/readme.md

* Update keyboards/bat43/rules.mk

* Remove unnecessary parts

* converted to Kxy format

* Update keyboards/bat43/bat43.h
@yfuku yfuku deleted the topic_bat43 branch February 12, 2021 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yfuku @noroadsleft @drashna @fauxpark