Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Korean keymap #8635

Merged
merged 3 commits into from
Apr 5, 2020
Merged

Add Korean keymap #8635

merged 3 commits into from
Apr 5, 2020

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Apr 1, 2020

Description

🇰🇷

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team April 1, 2020 03:15
vomindoraan
vomindoraan suggested changes Apr 1, 2020
View reviewed changes
quantum/keymap_extras/keymap_korean.h Outdated Show resolved Hide resolved
quantum/keymap_extras/keymap_korean.h Outdated Show resolved Hide resolved
quantum/keymap_extras/keymap_korean.h Show resolved Hide resolved
quantum/keymap_extras/keymap_korean.h Outdated Show resolved Hide resolved
quantum/keymap_extras/keymap_korean.h Outdated Show resolved Hide resolved
quantum/keymap_extras/keymap_korean.h Show resolved Hide resolved
@drashna drashna requested a review from a team April 2, 2020 06:55
vomindoraan
vomindoraan suggested changes Apr 4, 2020
View reviewed changes
quantum/keymap_extras/keymap_korean.h Outdated Show resolved Hide resolved
quantum/keymap_extras/keymap_korean.h
Comment on lines +88 to +89
#define KR_HANJ KC_LANG2 // Hanja (한자)
#define KR_HAEN KC_LANG1 // Han ↔ Yeong (한 ↔ 영)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the existing KC_HANJ and KC_HAEN aliases be used as the values here?

Suggested change
#define KR_HANJ KC_LANG2 // Hanja (한자)
#define KR_HAEN KC_LANG1 // Han ↔ Yeong (한 ↔ 영)
#define KR_HANJ KC_HANJ // Hanja (한자)
#define KR_HAEN KC_HAEN // Han ↔ Yeong (한 ↔ 영)

Copy link
Member Author

@fauxpark fauxpark Apr 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the language/int keycodes are both language and layout specific my thinking is their aliases should actually be removed from keycode.h, and users encouraged to include these headers instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me.

vomindoraan
vomindoraan approved these changes Apr 4, 2020
View reviewed changes
Copy link
Contributor

@vomindoraan vomindoraan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Will you be adding sendstring LUTs too as part of this PR?

@fauxpark
Copy link
Member Author

fauxpark commented Apr 4, 2020

They would be identical to the default US ANSI tables (with the exception of \ being ₩ because there is no backslash with this layout).

@vomindoraan
Copy link
Contributor

You're right, never mind 😃

@drashna drashna merged commit c5efbc4 into qmk:master Apr 5, 2020
@fauxpark fauxpark deleted the keymap-extras-korean branch April 5, 2020 08:15
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Apr 10, 2020
@fauxpark @vomindoraan @HokieGeek
Add Korean keymap (qmk#8635)
2082241 
* Add Korean keymap

* Switch to ANSI layout

* Update quantum/keymap_extras/keymap_korean.h

Co-Authored-By: Konstantin Đorđević <[email protected]>

Co-authored-by: Konstantin Đorđević <[email protected]>
Quarren42 pushed a commit to Quarren42/qmk_firmware that referenced this pull request Apr 15, 2020
@fauxpark @vomindoraan @Quarren42
Add Korean keymap (qmk#8635)
a99a57f 
* Add Korean keymap

* Switch to ANSI layout

* Update quantum/keymap_extras/keymap_korean.h

Co-Authored-By: Konstantin Đorđević <[email protected]>

Co-authored-by: Konstantin Đorđević <[email protected]>
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@fauxpark @vomindoraan @kujawakk
Add Korean keymap (qmk#8635)
15e9687 
* Add Korean keymap

* Switch to ANSI layout

* Update quantum/keymap_extras/keymap_korean.h

Co-Authored-By: Konstantin Đorđević <[email protected]>

Co-authored-by: Konstantin Đorđević <[email protected]>
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@fauxpark @vomindoraan @lorenzoernesto
Add Korean keymap (qmk#8635)
a80c80a 
* Add Korean keymap

* Switch to ANSI layout

* Update quantum/keymap_extras/keymap_korean.h

Co-Authored-By: Konstantin Đorđević <[email protected]>

Co-authored-by: Konstantin Đorđević <[email protected]>
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
@fauxpark @vomindoraan @drashna
Add Korean keymap (qmk#8635)
b0456fb 
* Add Korean keymap

* Switch to ANSI layout

* Update quantum/keymap_extras/keymap_korean.h

Co-Authored-By: Konstantin Đorđević <[email protected]>

Co-authored-by: Konstantin Đorđević <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@fauxpark @vomindoraan @sowbug
Add Korean keymap (qmk#8635)
7a17ed3 
* Add Korean keymap

* Switch to ANSI layout

* Update quantum/keymap_extras/keymap_korean.h

Co-Authored-By: Konstantin Đorđević <[email protected]>

Co-authored-by: Konstantin Đorđević <[email protected]>
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Jun 11, 2020
Merge remote-tracking branch 'upstream/master'
851f7c2 
* upstream/master: (312 commits)
  updated rules.mk and default keymap of Wonderland for VIA support (qmk#8668)
  Added Caps Lock LED handler to wilba.tech PCBs (qmk#8660)
  Add keyboard TGR-910 (qmk#8683)
  V-USB remote wakeup (qmk#7627)
  Add Greek keymap (qmk#8636)
  Add Polish keymap (qmk#8637)
  Add Korean keymap (qmk#8635)
  [Keyboard] Add 60_hhkb layout to hhkb (qmk#8618)
  [Keyboard] romeo - add via layout (qmk#8667)
  [Keyboard] Add ReverseStudio-DecadePad (qmk#8553)
  [Keyboard] Add bat43 Keyboard (qmk#8648)
  minor tweaks
  Fix saving output from avrdude and dfu-programmer
  Use version_arg in ESSENTIAL_BINARIES dict
  Fixes qmk#8541 by getting version from -dumpversion then --version as fallback
  VIA Support: 1upkeyboards Sweet16 (qmk#8652)
  [Keyboard] Lattice60 (qmk#8603)
  Discipline - Add ISO compatibility, rawHID enable, via layout (qmk#8627)
  [Keyboard] Add Orbit-X Keyboard (qmk#8605)
  add 60_tsangan_hhkb layout to GH60 rev. C (qmk#8617)
  ...
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jun 12, 2020
@fauxpark @vomindoraan @fdidron
Add Korean keymap (qmk#8635)
b34f369 
* Add Korean keymap

* Switch to ANSI layout

* Update quantum/keymap_extras/keymap_korean.h

Co-Authored-By: Konstantin Đorđević <[email protected]>

Co-authored-by: Konstantin Đorđević <[email protected]>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@fauxpark @vomindoraan @jakobaa
Add Korean keymap (qmk#8635)
590f5be 
* Add Korean keymap

* Switch to ANSI layout

* Update quantum/keymap_extras/keymap_korean.h

Co-Authored-By: Konstantin Đorđević <[email protected]>

Co-authored-by: Konstantin Đorđević <[email protected]>
thorstenweber83 pushed a commit to thorstenweber83/qmk_firmware that referenced this pull request Sep 2, 2020
@fauxpark @vomindoraan @thorstenweber83
Add Korean keymap (qmk#8635)
30766ac 
* Add Korean keymap

* Switch to ANSI layout

* Update quantum/keymap_extras/keymap_korean.h

Co-Authored-By: Konstantin Đorđević <[email protected]>

Co-authored-by: Konstantin Đorđević <[email protected]>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark @vomindoraan
Add Korean keymap (qmk#8635)
2919106 
* Add Korean keymap

* Switch to ANSI layout

* Update quantum/keymap_extras/keymap_korean.h

Co-Authored-By: Konstantin Đorđević <[email protected]>

Co-authored-by: Konstantin Đorđević <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@vomindoraan vomindoraan vomindoraan approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @vomindoraan @drashna