-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V-USB remote wakeup #7627
V-USB remote wakeup #7627
Conversation
Thank you for your contribution! |
89d92d9
to
1a386c4
Compare
Backport from tmk/tmk_keyboard@391c979
1a386c4
to
e951d01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working on Plaid-Pad where previously it did not with Windows. macOS does not suspend USB devices (at least, not by default?) so it works regardless.
Only thing that is needed is to incorporate this change, if only to be compliant:
diff --git a/tmk_core/protocol/vusb/vusb.c b/tmk_core/protocol/vusb/vusb.c
index 00314ebe8..470d29ba3 100644
--- a/tmk_core/protocol/vusb/vusb.c
+++ b/tmk_core/protocol/vusb/vusb.c
@@ -521,11 +521,7 @@ const PROGMEM usbConfigurationDescriptor_t usbConfigurationDescriptor = {
# endif
.bConfigurationValue = 0x01,
.iConfiguration = 0x00,
-# if USB_CFG_IS_SELF_POWERED
- .bmAttributes = (1 << 7) | USBATTR_SELFPOWER,
-# else
- .bmAttributes = (1 << 7),
-# endif
+ .bmAttributes = (1 << 7) | USBATTR_REMOTEWAKE,
.bMaxPower = USB_MAX_POWER_CONSUMPTION / 2
},
Otherwise, 👍
as per @fauxpark's suggestion
* V-USB remote wakeup Backport from tmk/tmk_keyboard@391c979 * Change vusb.c remote wake config as per fauxpark's suggestion
* V-USB remote wakeup Backport from tmk/tmk_keyboard@391c979 * Change vusb.c remote wake config as per fauxpark's suggestion
* V-USB remote wakeup Backport from tmk/tmk_keyboard@391c979 * Change vusb.c remote wake config as per fauxpark's suggestion
* V-USB remote wakeup Backport from tmk/tmk_keyboard@391c979 * Change vusb.c remote wake config as per fauxpark's suggestion
* V-USB remote wakeup Backport from tmk/tmk_keyboard@391c979 * Change vusb.c remote wake config as per fauxpark's suggestion
* V-USB remote wakeup Backport from tmk/tmk_keyboard@391c979 * Change vusb.c remote wake config as per fauxpark's suggestion
* V-USB remote wakeup Backport from tmk/tmk_keyboard@391c979 * Change vusb.c remote wake config as per fauxpark's suggestion
* upstream/master: (312 commits) updated rules.mk and default keymap of Wonderland for VIA support (qmk#8668) Added Caps Lock LED handler to wilba.tech PCBs (qmk#8660) Add keyboard TGR-910 (qmk#8683) V-USB remote wakeup (qmk#7627) Add Greek keymap (qmk#8636) Add Polish keymap (qmk#8637) Add Korean keymap (qmk#8635) [Keyboard] Add 60_hhkb layout to hhkb (qmk#8618) [Keyboard] romeo - add via layout (qmk#8667) [Keyboard] Add ReverseStudio-DecadePad (qmk#8553) [Keyboard] Add bat43 Keyboard (qmk#8648) minor tweaks Fix saving output from avrdude and dfu-programmer Use version_arg in ESSENTIAL_BINARIES dict Fixes qmk#8541 by getting version from -dumpversion then --version as fallback VIA Support: 1upkeyboards Sweet16 (qmk#8652) [Keyboard] Lattice60 (qmk#8603) Discipline - Add ISO compatibility, rawHID enable, via layout (qmk#8627) [Keyboard] Add Orbit-X Keyboard (qmk#8605) add 60_tsangan_hhkb layout to GH60 rev. C (qmk#8617) ...
* V-USB remote wakeup Backport from tmk/tmk_keyboard@391c979 * Change vusb.c remote wake config as per fauxpark's suggestion
* V-USB remote wakeup Backport from tmk/tmk_keyboard@391c979 * Change vusb.c remote wake config as per fauxpark's suggestion
* V-USB remote wakeup Backport from tmk/tmk_keyboard@391c979 * Change vusb.c remote wake config as per fauxpark's suggestion
* V-USB remote wakeup Backport from tmk/tmk_keyboard@391c979 * Change vusb.c remote wake config as per fauxpark's suggestion
Backport from tmk/tmk_keyboard@391c979
I don't have any vusb boards to test this one, so it may need somebody like @mechmerlin to test it.
Types of Changes