[Keyboard] Add 60_hhkb layout to hhkb #8618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Rubin <[email protected]>
noroadsleft
approved these changes
Apr 3, 2020
There was a problem hiding this comment.
I do want it on record that I've grown a distaste for having layout macros implemented as aliases for other macros, and would prefer using only the explicit names where appropriate, but I feel that is a task for another day.
HHKB codebase probably needs a fairly major refactor anyway.
drashna
approved these changes
Apr 5, 2020
|
Merge conflicts appear to be unrelated to this change. |
drashna
changed the title
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Apr 10, 2020
Signed-off-by: Joshua Rubin <[email protected]>
Quarren42
pushed a commit
to Quarren42/qmk_firmware
that referenced
this pull request
Apr 15, 2020
Signed-off-by: Joshua Rubin <[email protected]>
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
Signed-off-by: Joshua Rubin <[email protected]>
bitherder
pushed a commit
to bitherder/qmk_firmware
that referenced
this pull request
May 15, 2020
Signed-off-by: Joshua Rubin <[email protected]>
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
May 24, 2020
Signed-off-by: Joshua Rubin <[email protected]>
nesth
pushed a commit
to nesth/qmk_firmware
that referenced
this pull request
Jun 11, 2020
* upstream/master: (312 commits) updated rules.mk and default keymap of Wonderland for VIA support (qmk#8668) Added Caps Lock LED handler to wilba.tech PCBs (qmk#8660) Add keyboard TGR-910 (qmk#8683) V-USB remote wakeup (qmk#7627) Add Greek keymap (qmk#8636) Add Polish keymap (qmk#8637) Add Korean keymap (qmk#8635) [Keyboard] Add 60_hhkb layout to hhkb (qmk#8618) [Keyboard] romeo - add via layout (qmk#8667) [Keyboard] Add ReverseStudio-DecadePad (qmk#8553) [Keyboard] Add bat43 Keyboard (qmk#8648) minor tweaks Fix saving output from avrdude and dfu-programmer Use version_arg in ESSENTIAL_BINARIES dict Fixes qmk#8541 by getting version from -dumpversion then --version as fallback VIA Support: 1upkeyboards Sweet16 (qmk#8652) [Keyboard] Lattice60 (qmk#8603) Discipline - Add ISO compatibility, rawHID enable, via layout (qmk#8627) [Keyboard] Add Orbit-X Keyboard (qmk#8605) add 60_tsangan_hhkb layout to GH60 rev. C (qmk#8617) ...
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
Signed-off-by: Joshua Rubin <[email protected]>
thorstenweber83
pushed a commit
to thorstenweber83/qmk_firmware
that referenced
this pull request
Sep 2, 2020
Signed-off-by: Joshua Rubin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the hhkb keyboard such that it satisfies the
60_hhkblayout. I implemented this in the most minimal way possible with a simple#define LAYOUT_60_hhkb LAYOUT, though if this is frowned on, I can update all instances ofLAYOUTto beLAYOUT_60_hhkbinstead.Types of Changes
Checklist