Remove file with same name and different case #6028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noroadsleft
requested changes
May 31, 2019
|
Sorry, I missed that. And yeah, we prefer lowercase names, as it's less prone to "odd issues". |
alexspeller
force-pushed
the
remove-same-named-file
branch
from
24013dd to
b97986d
Compare
alexspeller
force-pushed
the
remove-same-named-file
branch
from
b97986d to
24d0e1a
Compare
|
Makes sense, I renamed to lowercase |
duncanyoyo1
added a commit
to duncanyoyo1/qmk_firmware
that referenced
this pull request
May 31, 2019
[Keyboard] Remove file with same name and different case (qmk#6028)
|
Whoops! Thanks for catching that. |
tenderlove
added a commit
to tenderlove/qmk_firmware
that referenced
this pull request
Jun 10, 2019
* master: (790 commits) [Keyboard] YMD96 refactor (qmk#5472) Update reference_configurator_support.md Use qmk docker image for travis CI builds [Keyboard] Remove file with same name and different case (qmk#6028) [Keyboard] Fix json for NK65 (qmk#6026) [Keymap] added hhkb layout for tada68 (qmk#6027) [Keymap] Added keymap for user jasondunsmore (qmk#6023) [Keyboard] Fix jc65 when RGB or BACKLIGHT disabled (qmk#6022) Update feature_encoders.md Copy avr teensy flash logic to arm (qmk#6016) [Keyboard] E6V2 R2 BMC PCB (qmk#6009) Add belgian layout for sendstring (qmk#6008) [Keyboard] Added XW60 PCB (qmk#6011) [Keymap] Georgi flippydippy layout (qmk#6005) Fix TO() and DF() calling layer_state_set_[kb,user] twice (qmk#6003) Update 333fred keymaps and add new iris map. (qmk#6010) [Keyboard] Changed LED positions for Massdrop CTRL and DZ60RGB (qmk#5801) [Keyboard] Add support for AKB boards (qmk#5996) Duck Octagon V1 Configurator cleanup (qmk#5957) Fixing matrix_scan so it properly returns changed status ...
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
kimat
pushed a commit
to kimat/qmk_firmware
that referenced
this pull request
Sep 8, 2019
benjaminmikiten
pushed a commit
to benjaminmikiten/qmk_firmware
that referenced
this pull request
Sep 29, 2019
benjaminmikiten
pushed a commit
to benjaminmikiten/qmk_firmware
that referenced
this pull request
Dec 18, 2019
benjaminmikiten
added a commit
to benjaminmikiten/qmk_firmware
that referenced
this pull request
Dec 18, 2019
…ware into develop * 'develop' of https://github.com/benjaminmikiten/qmk_firmware: (42 commits) userspace work preonic edits work update dvorak add hexpad, bootmagic split version of xd75 rewrite XD75 lauyout for left-hand keypad add enter, clicky toggle, switch song redo preonic Update keymap.c restore songs swap lower, raise create preonic layout add xd75 keymap fix plaid adjust layer update gitignore [Keyboard] Remove file with same name and different case (qmk#6028) Ignore VSCode ipsh folder (qmk#5741) add infinity ergodox customize keymap some ... # Conflicts: # keyboards/preonic/keymaps/benjaminmikiten/config.h # keyboards/preonic/keymaps/benjaminmikiten/keymap.c # keyboards/preonic/keymaps/benjaminmikiten/rules.mk # keyboards/romac/rules.mk # keyboards/xd75/keymaps/benjaminmikiten/keymap.c # keyboards/xd75/keymaps/benjaminmikiten/rules.mk # users/benjaminmikiten/benjaminmikiten.h # users/benjaminmikiten/readme.md
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
JeffreyPalmer
pushed a commit
to JeffreyPalmer/qmk_firmware
that referenced
this pull request
Feb 27, 2020
swamp09
pushed a commit
to swamp09/qmk_firmware
that referenced
this pull request
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#6027 includes two files named the same but with different case. This breaks git on case-insensitive filesystems (like MacOS by default) - @drashna @noroadsleft mentioning you as you were reviewers on that PR
Types of Changes
Checklist