Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AKB boards #5996

Merged
merged 4 commits into from
May 29, 2019
Merged

Add support for AKB boards #5996

merged 4 commits into from
May 29, 2019

Conversation

e11i0t23
Copy link
Contributor

Description

Add support for AKB keyboards including raine m3 and eb46

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/akb/eb46/info.json Outdated Show resolved Hide resolved
keyboards/akb/raine/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/akb/raine/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/akb/raine/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/akb/raine/info.json Outdated Show resolved Hide resolved
keyboards/akb/raine/config.h Show resolved Hide resolved
keyboards/akb/raine/raine.h Outdated Show resolved Hide resolved
keyboards/akb/eb46/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/akb/eb46/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/akb/eb46/readme.md Outdated Show resolved Hide resolved
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your objects in info.json are out-of-order with respect to your layout macro and keymap.c.

keyboards/akb/raine/info.json Show resolved Hide resolved
keyboards/akb/raine/info.json Outdated Show resolved Hide resolved
keyboards/akb/raine/info.json Outdated Show resolved Hide resolved
keyboards/akb/raine/info.json Show resolved Hide resolved
keyboards/akb/raine/info.json Show resolved Hide resolved
keyboards/akb/raine/info.json Outdated Show resolved Hide resolved
keyboards/akb/raine/info.json Outdated Show resolved Hide resolved
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@drashna
Copy link
Member

drashna commented May 29, 2019

Thanks!

@drashna drashna merged commit bd1cfcd into qmk:master May 29, 2019
@e11i0t23 e11i0t23 deleted the akb branch May 31, 2019 19:25
tenderlove added a commit to tenderlove/qmk_firmware that referenced this pull request Jun 10, 2019
* master: (790 commits)
  [Keyboard] YMD96 refactor (qmk#5472)
  Update reference_configurator_support.md
  Use qmk docker image for travis CI builds
  [Keyboard] Remove file with same name and different case (qmk#6028)
  [Keyboard] Fix json for NK65 (qmk#6026)
  [Keymap] added hhkb layout for tada68 (qmk#6027)
  [Keymap] Added keymap for user jasondunsmore (qmk#6023)
  [Keyboard] Fix jc65 when RGB or BACKLIGHT disabled (qmk#6022)
  Update feature_encoders.md
  Copy avr teensy flash logic to arm (qmk#6016)
  [Keyboard] E6V2 R2 BMC PCB (qmk#6009)
  Add belgian layout for sendstring (qmk#6008)
  [Keyboard] Added XW60 PCB (qmk#6011)
  [Keymap] Georgi flippydippy layout (qmk#6005)
  Fix TO() and DF() calling layer_state_set_[kb,user] twice (qmk#6003)
  Update 333fred keymaps and add new iris map. (qmk#6010)
  [Keyboard] Changed LED positions for Massdrop CTRL and DZ60RGB (qmk#5801)
  [Keyboard] Add support for AKB boards (qmk#5996)
  Duck Octagon V1 Configurator cleanup (qmk#5957)
  Fixing matrix_scan so it properly returns changed status
  ...
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
* Move boards to akb folder

* Updates for PR

* fix for PR

* Fix info.json
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
* Move boards to akb folder

* Updates for PR

* fix for PR

* Fix info.json
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
* Move boards to akb folder

* Updates for PR

* fix for PR

* Fix info.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants