Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E6V2 R2 BMC PCB #6009

Merged
merged 6 commits into from
May 29, 2019
Merged

E6V2 R2 BMC PCB #6009

merged 6 commits into from
May 29, 2019

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented May 29, 2019

Description

The R2 e6v2 BMC PCB is actually a brand new PCB that differs from the R1 by only 1 key. This PR is "almost" identical to oe_bmc with the exception of the spacebar key.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechmerlin mechmerlin requested a review from drashna May 29, 2019 03:39
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

# Build Options
# change yes to no to disable
#
BOOTMAGIC_ENABLE = no # Virtual DIP switch configuration(+1000)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No bootmagic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BMC isn't magical enough to support boot magic.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right.

@drashna drashna merged commit 786ee9c into qmk:master May 29, 2019
@mechmerlin mechmerlin deleted the feature/lebmc branch June 8, 2019 15:51
tenderlove added a commit to tenderlove/qmk_firmware that referenced this pull request Jun 10, 2019
* master: (790 commits)
  [Keyboard] YMD96 refactor (qmk#5472)
  Update reference_configurator_support.md
  Use qmk docker image for travis CI builds
  [Keyboard] Remove file with same name and different case (qmk#6028)
  [Keyboard] Fix json for NK65 (qmk#6026)
  [Keymap] added hhkb layout for tada68 (qmk#6027)
  [Keymap] Added keymap for user jasondunsmore (qmk#6023)
  [Keyboard] Fix jc65 when RGB or BACKLIGHT disabled (qmk#6022)
  Update feature_encoders.md
  Copy avr teensy flash logic to arm (qmk#6016)
  [Keyboard] E6V2 R2 BMC PCB (qmk#6009)
  Add belgian layout for sendstring (qmk#6008)
  [Keyboard] Added XW60 PCB (qmk#6011)
  [Keymap] Georgi flippydippy layout (qmk#6005)
  Fix TO() and DF() calling layer_state_set_[kb,user] twice (qmk#6003)
  Update 333fred keymaps and add new iris map. (qmk#6010)
  [Keyboard] Changed LED positions for Massdrop CTRL and DZ60RGB (qmk#5801)
  [Keyboard] Add support for AKB boards (qmk#5996)
  Duck Octagon V1 Configurator cleanup (qmk#5957)
  Fixing matrix_scan so it properly returns changed status
  ...
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
* initial commit

* remove mentions of oe and replace with le

* add new layout macros with the spacebar change

* add rgb underglow support

* Update keyboards/exclusive/e6v2/le_bmc/rules.mk

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/exclusive/e6v2/le_bmc/readme.md

Co-Authored-By: noroadsleft <[email protected]>
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
* initial commit

* remove mentions of oe and replace with le

* add new layout macros with the spacebar change

* add rgb underglow support

* Update keyboards/exclusive/e6v2/le_bmc/rules.mk

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/exclusive/e6v2/le_bmc/readme.md

Co-Authored-By: noroadsleft <[email protected]>
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
* initial commit

* remove mentions of oe and replace with le

* add new layout macros with the spacebar change

* add rgb underglow support

* Update keyboards/exclusive/e6v2/le_bmc/rules.mk

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/exclusive/e6v2/le_bmc/readme.md

Co-Authored-By: noroadsleft <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants