Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

belgian layout had no sendstring definition #6008

Merged
merged 5 commits into from
May 29, 2019

Conversation

kimat
Copy link
Contributor

@kimat kimat commented May 28, 2019

Note that you have to send the dead keys twice: tilda, circ.

Tested with the following :

SEND_STRING(" !\"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^^``_abcdefghijklmnopqrstuvwxyz{|}~~");

And what the keyboard typed when triggered:

 !"#$%&'()*+,-.+0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]^_abcdefghijklmnopqrstuvwxyz{|}

Note that the deadkey backtick (grave accent) isn't displayed for some reason

@noroadsleft
Copy link
Member

@kimat Welcome!

Am I correct in understanding that these changes don't fully enable the full sendstring charset, because some of the characters are used as dead keys in Belgium? I'm American so my experience here is limited. As I recall, to get the character of a dead key, rather than combine it with a key to get an accented character, you need to use the dead key followed by Space. Is that correct? Trying to think of a solution for the future.

@fauxpark
Copy link
Member

The Belgian keyboard layout (red are dead keys):

Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I've just made a couple tweaks to get the backtick character working (as far as I can tell from the image I posted), and also changed as many of the keycodes as possible to their language-specific aliases.

quantum/keymap_extras/sendstring_belgian.h Outdated Show resolved Hide resolved
quantum/keymap_extras/sendstring_belgian.h Outdated Show resolved Hide resolved
quantum/keymap_extras/sendstring_belgian.h Outdated Show resolved Hide resolved
quantum/keymap_extras/sendstring_belgian.h Outdated Show resolved Hide resolved
quantum/keymap_extras/sendstring_belgian.h Outdated Show resolved Hide resolved
quantum/keymap_extras/sendstring_belgian.h Outdated Show resolved Hide resolved
quantum/keymap_extras/sendstring_belgian.h Outdated Show resolved Hide resolved
quantum/keymap_extras/sendstring_belgian.h Outdated Show resolved Hide resolved
@kimat
Copy link
Contributor Author

kimat commented May 29, 2019

I fixed backtick which I forgot to define... And I fixed slash. Thanks @fauxpark.

@fauxpark I for one think of @ as altgr+2 and not altgr+é, and I'd argue this makes makes the current format easier to read.

@noroadsleft thanks,
The full sendstring charset can be sent now. It does require doubling, which is what you would naturally do when typing, or adding a space after dead keys to have them display. Something better could be envisionned but this works already.
Sendstring could actually support more keys than the 128 ascii chars by combining e.g. ralt and shift or allowing e.g. BE_EACU through without modifiers.

@fauxpark
Copy link
Member

I see what you mean, but in this layout 2 is Shift+é, so AltGr+2 would actually mean AltGr+Shift+é. It makes much more sense to me to use the base unshifted language-specific keycodes here to demonstrate why the Shift and AltGr tables exist.

@kimat kimat force-pushed the sendstring-for-belgian-layout branch from 8d2a145 to c4954a9 Compare May 29, 2019 17:08
@kimat
Copy link
Contributor Author

kimat commented May 29, 2019

So we are down to two dead keys ~ and ` that need an extra space in the sendstring but we have the full sendstring charset.

@kimat kimat force-pushed the sendstring-for-belgian-layout branch from c4954a9 to 46f8150 Compare May 29, 2019 17:12
@drashna
Copy link
Member

drashna commented May 29, 2019

Just to make sure, is this read to go (as is), or does it need more time?

@kimat
Copy link
Contributor Author

kimat commented May 29, 2019

@drashna It's ready to go.

@drashna
Copy link
Member

drashna commented May 29, 2019

Awesome, thanks!

@drashna drashna merged commit 4d97f35 into qmk:master May 29, 2019
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 29, 2019
* belgian layout had no sendstring definition

* backtick was not defined for belgian sendstring

* slash definition was wrong for belgian sendstring

Co-Authored-By: fauxpark <[email protected]>

* use BE_ keys whenever we can

Co-Authored-By: fauxpark <[email protected]>

* ^ can be sent as a normal key (not a dead key) with altgr+para
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jun 4, 2019
* belgian layout had no sendstring definition

* backtick was not defined for belgian sendstring

* slash definition was wrong for belgian sendstring

Co-Authored-By: fauxpark <[email protected]>

* use BE_ keys whenever we can

Co-Authored-By: fauxpark <[email protected]>

* ^ can be sent as a normal key (not a dead key) with altgr+para
tenderlove added a commit to tenderlove/qmk_firmware that referenced this pull request Jun 10, 2019
* master: (790 commits)
  [Keyboard] YMD96 refactor (qmk#5472)
  Update reference_configurator_support.md
  Use qmk docker image for travis CI builds
  [Keyboard] Remove file with same name and different case (qmk#6028)
  [Keyboard] Fix json for NK65 (qmk#6026)
  [Keymap] added hhkb layout for tada68 (qmk#6027)
  [Keymap] Added keymap for user jasondunsmore (qmk#6023)
  [Keyboard] Fix jc65 when RGB or BACKLIGHT disabled (qmk#6022)
  Update feature_encoders.md
  Copy avr teensy flash logic to arm (qmk#6016)
  [Keyboard] E6V2 R2 BMC PCB (qmk#6009)
  Add belgian layout for sendstring (qmk#6008)
  [Keyboard] Added XW60 PCB (qmk#6011)
  [Keymap] Georgi flippydippy layout (qmk#6005)
  Fix TO() and DF() calling layer_state_set_[kb,user] twice (qmk#6003)
  Update 333fred keymaps and add new iris map. (qmk#6010)
  [Keyboard] Changed LED positions for Massdrop CTRL and DZ60RGB (qmk#5801)
  [Keyboard] Add support for AKB boards (qmk#5996)
  Duck Octagon V1 Configurator cleanup (qmk#5957)
  Fixing matrix_scan so it properly returns changed status
  ...
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
* belgian layout had no sendstring definition

* backtick was not defined for belgian sendstring

* slash definition was wrong for belgian sendstring

Co-Authored-By: fauxpark <[email protected]>

* use BE_ keys whenever we can

Co-Authored-By: fauxpark <[email protected]>

* ^ can be sent as a normal key (not a dead key) with altgr+para
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
* belgian layout had no sendstring definition

* backtick was not defined for belgian sendstring

* slash definition was wrong for belgian sendstring

Co-Authored-By: fauxpark <[email protected]>

* use BE_ keys whenever we can

Co-Authored-By: fauxpark <[email protected]>

* ^ can be sent as a normal key (not a dead key) with altgr+para
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
* belgian layout had no sendstring definition

* backtick was not defined for belgian sendstring

* slash definition was wrong for belgian sendstring

Co-Authored-By: fauxpark <[email protected]>

* use BE_ keys whenever we can

Co-Authored-By: fauxpark <[email protected]>

* ^ can be sent as a normal key (not a dead key) with altgr+para
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* belgian layout had no sendstring definition

* backtick was not defined for belgian sendstring

* slash definition was wrong for belgian sendstring

Co-Authored-By: fauxpark <[email protected]>

* use BE_ keys whenever we can

Co-Authored-By: fauxpark <[email protected]>

* ^ can be sent as a normal key (not a dead key) with altgr+para
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants