-
-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
belgian layout had no sendstring definition #6008
Conversation
@kimat Welcome! Am I correct in understanding that these changes don't fully enable the full sendstring charset, because some of the characters are used as dead keys in Belgium? I'm American so my experience here is limited. As I recall, to get the character of a dead key, rather than combine it with a key to get an accented character, you need to use the dead key followed by Space. Is that correct? Trying to think of a solution for the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I've just made a couple tweaks to get the backtick character working (as far as I can tell from the image I posted), and also changed as many of the keycodes as possible to their language-specific aliases.
I fixed backtick which I forgot to define... And I fixed slash. Thanks @fauxpark. @fauxpark I for one think of @ as altgr+2 and not altgr+é, and I'd argue this makes makes the current format easier to read. @noroadsleft thanks, |
I see what you mean, but in this layout |
8d2a145
to
c4954a9
Compare
So we are down to two dead keys ~ and ` that need an extra space in the sendstring but we have the full sendstring charset. |
Co-Authored-By: fauxpark <[email protected]>
Co-Authored-By: fauxpark <[email protected]>
c4954a9
to
46f8150
Compare
Just to make sure, is this read to go (as is), or does it need more time? |
@drashna It's ready to go. |
Awesome, thanks! |
* belgian layout had no sendstring definition * backtick was not defined for belgian sendstring * slash definition was wrong for belgian sendstring Co-Authored-By: fauxpark <[email protected]> * use BE_ keys whenever we can Co-Authored-By: fauxpark <[email protected]> * ^ can be sent as a normal key (not a dead key) with altgr+para
* belgian layout had no sendstring definition * backtick was not defined for belgian sendstring * slash definition was wrong for belgian sendstring Co-Authored-By: fauxpark <[email protected]> * use BE_ keys whenever we can Co-Authored-By: fauxpark <[email protected]> * ^ can be sent as a normal key (not a dead key) with altgr+para
* master: (790 commits) [Keyboard] YMD96 refactor (qmk#5472) Update reference_configurator_support.md Use qmk docker image for travis CI builds [Keyboard] Remove file with same name and different case (qmk#6028) [Keyboard] Fix json for NK65 (qmk#6026) [Keymap] added hhkb layout for tada68 (qmk#6027) [Keymap] Added keymap for user jasondunsmore (qmk#6023) [Keyboard] Fix jc65 when RGB or BACKLIGHT disabled (qmk#6022) Update feature_encoders.md Copy avr teensy flash logic to arm (qmk#6016) [Keyboard] E6V2 R2 BMC PCB (qmk#6009) Add belgian layout for sendstring (qmk#6008) [Keyboard] Added XW60 PCB (qmk#6011) [Keymap] Georgi flippydippy layout (qmk#6005) Fix TO() and DF() calling layer_state_set_[kb,user] twice (qmk#6003) Update 333fred keymaps and add new iris map. (qmk#6010) [Keyboard] Changed LED positions for Massdrop CTRL and DZ60RGB (qmk#5801) [Keyboard] Add support for AKB boards (qmk#5996) Duck Octagon V1 Configurator cleanup (qmk#5957) Fixing matrix_scan so it properly returns changed status ...
* belgian layout had no sendstring definition * backtick was not defined for belgian sendstring * slash definition was wrong for belgian sendstring Co-Authored-By: fauxpark <[email protected]> * use BE_ keys whenever we can Co-Authored-By: fauxpark <[email protected]> * ^ can be sent as a normal key (not a dead key) with altgr+para
* belgian layout had no sendstring definition * backtick was not defined for belgian sendstring * slash definition was wrong for belgian sendstring Co-Authored-By: fauxpark <[email protected]> * use BE_ keys whenever we can Co-Authored-By: fauxpark <[email protected]> * ^ can be sent as a normal key (not a dead key) with altgr+para
* belgian layout had no sendstring definition * backtick was not defined for belgian sendstring * slash definition was wrong for belgian sendstring Co-Authored-By: fauxpark <[email protected]> * use BE_ keys whenever we can Co-Authored-By: fauxpark <[email protected]> * ^ can be sent as a normal key (not a dead key) with altgr+para
* belgian layout had no sendstring definition * backtick was not defined for belgian sendstring * slash definition was wrong for belgian sendstring Co-Authored-By: fauxpark <[email protected]> * use BE_ keys whenever we can Co-Authored-By: fauxpark <[email protected]> * ^ can be sent as a normal key (not a dead key) with altgr+para
Note that you have to send the dead keys twice: tilda, circ.
Tested with the following :
And what the keyboard typed when triggered:
Note that the deadkey backtick (grave accent) isn't displayed for some reason