Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem that Chidori is not recognized by host computer. #17882

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Fix problem that Chidori is not recognized by host computer. #17882

merged 1 commit into from
Sep 15, 2022

Conversation

ka2hiro
Copy link
Contributor

@ka2hiro ka2hiro commented Aug 3, 2022

Description

Added USB-related definitions to config.h that were changed by consolidated usbconfig.h.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@keyboard-magpie
Copy link
Contributor

Would you be able to provide some context as to what issues you were having, and how you have discovered these changes?

@ka2hiro
Copy link
Contributor Author

ka2hiro commented Aug 3, 2022

@keyboard-magpie
When I plugged Chidori, with the latest QMK written to it, into my computer, it was not recognized as a USB device.

I have not been following QMK updates for a while, so I checked the code in the latest the repository and noticed that usbconfig.h has been consolidate.

The consolidated usbconfig.h defined default values that were not defined in Chidori's old usbconfig.h, so I defined values to cancel them.

Hope this answers your question.

@keyboard-magpie
Copy link
Contributor

Thanks. I will try this on some of my VUSB boards I have here (although I personally have not had issues with recent QMK code). From running this past @zvecr briefly a concern may be how USB_COUNT_SOF interacts with suspend.

@pondodev
Copy link

pondodev commented Aug 3, 2022

@keyboard-magpie for what it's worth, my mate who had recently built a chidori found that latest on master showed this issue of not enumerating as a USB device. I have that chidori with me at the moment for testing and have been able to reliably reproduce this issue which is then fixed with this patch. interestingly enough though, i've not really experienced this issue on my one other keyboard running V-USB, a plaid. this said it is known to sometimes not be recognised by the host machine when plugged in so maybe this is the cause for that?

@drashna drashna requested review from fauxpark, zvecr and a team August 6, 2022 02:46
@ka2hiro
Copy link
Contributor Author

ka2hiro commented Sep 13, 2022

@drashna @fauxpark @zvecr
Hello, Is there any missing information to review this PR? If so, please let me know.

@drashna drashna requested a review from a team September 14, 2022 17:57
@zvecr zvecr merged commit f483520 into qmk:master Sep 15, 2022
ohlin added a commit to ohlin/qmk_firmware that referenced this pull request Sep 19, 2022
@ohlin
Merge branch 'master' into ko-kyria
520554d 
* master: (28 commits)
  [Docs] Extract 'Layer Change Code' and EEPROM (qmk#18174)
  Add home row modifiers to dshields keymaps. (qmk#18376)
  Reduce charue/sunsetter_r2 firmware size (qmk#18378)
  Add encoder map to BDN9 VIA keymap (qmk#18388)
  FIx ARRAYSIZE def and Murphpad string array (qmk#18392)
  Fixup axon40 lint. (qmk#18409)
  [keyboard] kbdfans/kbd75rgb info.json fix (qmk#18391)
  Bump anothrNick/github-tag-action from 1.45.0 to 1.46.0 (qmk#18386)
  Quark revision - rotary encoder and 7u support (qmk#17664)
  Initial support for Tetromino added (qmk#18341)
  Add ability to remove temporary files during multibuild. (qmk#18381)
  Fix handwired/swiftrax/bumblebee layout macro (qmk#18377)
  [Keyboard] Add pi40 (qmk#18207)
  [Keyboard] Removal of deprecated defines in IDOBAO keyboards (qmk#18358)
  Fix problem that Chidori is not recognized by host computer. (qmk#17882)
  [Keyboard] Add a new keyboard 'plum47' (qmk#18359)
  [Docs] RESET -> QK_BOOT (qmk#18365)
  Remove `RESET` keycodes from fjlabs keyboards (qmk#18364)
  [Keyboard] Add Vector PCB (qmk#17380)
  [Keyboard] Add Calice (qmk#17929)
  ...
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
@ka2hiro @tacahiroy
Fix problem that Chidori is not recognized by host computer. (qmk#17882)
87c84ec
SjB added a commit to SjB/qmk_firmware that referenced this pull request Oct 12, 2022
@SjB
Merge remote-tracking branch 'upstream/master' into sjb/all-keyboard
8def421 
* upstream/master: (319 commits)
  Fix handwired/swiftrax/bumblebee layout macro (qmk#18377)
  [Keyboard] Add pi40 (qmk#18207)
  [Keyboard] Removal of deprecated defines in IDOBAO keyboards (qmk#18358)
  Fix problem that Chidori is not recognized by host computer. (qmk#17882)
  [Keyboard] Add a new keyboard 'plum47' (qmk#18359)
  [Docs] RESET -> QK_BOOT (qmk#18365)
  Remove `RESET` keycodes from fjlabs keyboards (qmk#18364)
  [Keyboard] Add Vector PCB (qmk#17380)
  [Keyboard] Add Calice (qmk#17929)
  GeonWorks Frog Mini Soldered Layout Rework (qmk#18308)
  [Keyboard] Add skmt/15k keyboard (qmk#18321)
  [Keyboard] Replace Nayeon ATmega32u4 config with RP2040 (qmk#18265)
  Bump anothrNick/github-tag-action from 1.42.0 to 1.45.0 (qmk#18355)
  fix: Remove TERM_ON/TERM_OFF from my keymap (qmk#18354)
  Bump anothrNick/github-tag-action from 1.39.0 to 1.42.0 (qmk#18344)
  Fix keyboard_name for Unicomp Classic/Ultra Classic keyboards (qmk#18327)
  Add EM.8 keyboard  (qmk#18328)
  fixed missing x coordinate on spacebar (qmk#18330)
  GMMK2: Fix 'ISO' within product name (qmk#18322)
  Added gmmk v2 p65 keyboard. (qmk#18185)
  ...
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@ka2hiro @ramonimbao
Fix problem that Chidori is not recognized by host computer. (qmk#17882)
6bd0013
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@ka2hiro @nolanseaton
Fix problem that Chidori is not recognized by host computer. (qmk#17882)
48d3975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ka2hiro @keyboard-magpie @pondodev @drashna @fauxpark @zvecr