Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Extract 'Layer Change Code' and EEPROM #18174

Merged
merged 6 commits into from
Sep 19, 2022
Merged

[Docs] Extract 'Layer Change Code' and EEPROM #18174

merged 6 commits into from
Sep 19, 2022

Conversation

coliss86
Copy link
Contributor

Description

As described in #18089, here is a proposition of a reorganization of the custom_quantum_functions.md page.
I have also added a "legacy" content section as in feature_advanced_keycodes.md

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@spidey3
Copy link
Contributor

spidey3 commented Sep 6, 2022

I think this is a good start, but I wonder, should all of the subsections should be broken out, and this page just turned into an index...

@spidey3 spidey3 requested a review from a team September 6, 2022 20:39
@coliss86
Copy link
Contributor Author

coliss86 commented Sep 7, 2022

I think this is a good start, but I wonder, should all of the subsections should be broken out, and this page just turned into an index...

I'm sorry if I misunderstood:

  • do you ask to split the page into several pages ? or
  • you think that this page will become an index and it is not a good idea ?

@coliss86 coliss86 requested a review from spidey3 September 7, 2022 19:57
@spidey3
Copy link
Contributor

spidey3 commented Sep 9, 2022

  • do you ask to split the page into several pages ? or
  • you think that this page will become an index and it is not a good idea ?

Sorry - I didn't mean that to be a call to action, but more of a statement of fact, that eventually this page could just become an index (but not in this PR).

@spidey3 spidey3 requested a review from a team September 9, 2022 23:05
@zvecr zvecr merged commit 2c516fa into qmk:master Sep 19, 2022
ohlin added a commit to ohlin/qmk_firmware that referenced this pull request Sep 19, 2022
* master: (28 commits)
  [Docs] Extract 'Layer Change Code' and EEPROM (qmk#18174)
  Add home row modifiers to dshields keymaps. (qmk#18376)
  Reduce charue/sunsetter_r2 firmware size (qmk#18378)
  Add encoder map to BDN9 VIA keymap (qmk#18388)
  FIx ARRAYSIZE def and Murphpad string array (qmk#18392)
  Fixup axon40 lint. (qmk#18409)
  [keyboard] kbdfans/kbd75rgb info.json fix (qmk#18391)
  Bump anothrNick/github-tag-action from 1.45.0 to 1.46.0 (qmk#18386)
  Quark revision - rotary encoder and 7u support (qmk#17664)
  Initial support for Tetromino added (qmk#18341)
  Add ability to remove temporary files during multibuild. (qmk#18381)
  Fix handwired/swiftrax/bumblebee layout macro (qmk#18377)
  [Keyboard] Add pi40 (qmk#18207)
  [Keyboard] Removal of deprecated defines in IDOBAO keyboards (qmk#18358)
  Fix problem that Chidori is not recognized by host computer. (qmk#17882)
  [Keyboard] Add a new keyboard 'plum47' (qmk#18359)
  [Docs] RESET -> QK_BOOT (qmk#18365)
  Remove `RESET` keycodes from fjlabs keyboards (qmk#18364)
  [Keyboard] Add Vector PCB (qmk#17380)
  [Keyboard] Add Calice (qmk#17929)
  ...
@coliss86 coliss86 deleted the doc branch September 19, 2022 08:00
MichaelDavidGK added a commit to MichaelDavidGK/QMK-OpenRGB that referenced this pull request Sep 19, 2022
[Docs] Extract 'Layer Change Code' and EEPROM (qmk#18174)
MichaelDavidGK added a commit to MichaelDavidGK/QMK-OpenRGB that referenced this pull request Sep 19, 2022
[Docs] Extract 'Layer Change Code' and EEPROM (qmk#18174)
MichaelDavidGK added a commit to MichaelDavidGK/QMK-OpenRGB that referenced this pull request Sep 19, 2022
[Docs] Extract 'Layer Change Code' and EEPROM (qmk#18174)
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
* [Docs] Extract 'Layer Change Code' and EEPROM

* adjust wording

* Update docs/custom_quantum_functions.md

Co-authored-by: Joel Challis <[email protected]>

Co-authored-by: Joel Challis <[email protected]>
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
* [Docs] Extract 'Layer Change Code' and EEPROM

* adjust wording

* Update docs/custom_quantum_functions.md

Co-authored-by: Joel Challis <[email protected]>

Co-authored-by: Joel Challis <[email protected]>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
* [Docs] Extract 'Layer Change Code' and EEPROM

* adjust wording

* Update docs/custom_quantum_functions.md

Co-authored-by: Joel Challis <[email protected]>

Co-authored-by: Joel Challis <[email protected]>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
* [Docs] Extract 'Layer Change Code' and EEPROM

* adjust wording

* Update docs/custom_quantum_functions.md

Co-authored-by: Joel Challis <[email protected]>

Co-authored-by: Joel Challis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants