Initial support for Tetromino added #18341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboard-magpie
requested changes
Sep 12, 2022
drashna
requested changes
Sep 12, 2022
daskygit
reviewed
Sep 12, 2022
an-achronism
requested review from
drashna and
daskygit
and removed request for
drashna
an-achronism
requested review from
keyboard-magpie
and removed request for
daskygit
keyboard-magpie
approved these changes
Sep 12, 2022
drashna
approved these changes
Sep 14, 2022
daskygit
requested changes
Sep 14, 2022
ohlin
added a commit
to ohlin/qmk_firmware
that referenced
this pull request
Sep 19, 2022
* master: (28 commits) [Docs] Extract 'Layer Change Code' and EEPROM (qmk#18174) Add home row modifiers to dshields keymaps. (qmk#18376) Reduce charue/sunsetter_r2 firmware size (qmk#18378) Add encoder map to BDN9 VIA keymap (qmk#18388) FIx ARRAYSIZE def and Murphpad string array (qmk#18392) Fixup axon40 lint. (qmk#18409) [keyboard] kbdfans/kbd75rgb info.json fix (qmk#18391) Bump anothrNick/github-tag-action from 1.45.0 to 1.46.0 (qmk#18386) Quark revision - rotary encoder and 7u support (qmk#17664) Initial support for Tetromino added (qmk#18341) Add ability to remove temporary files during multibuild. (qmk#18381) Fix handwired/swiftrax/bumblebee layout macro (qmk#18377) [Keyboard] Add pi40 (qmk#18207) [Keyboard] Removal of deprecated defines in IDOBAO keyboards (qmk#18358) Fix problem that Chidori is not recognized by host computer. (qmk#17882) [Keyboard] Add a new keyboard 'plum47' (qmk#18359) [Docs] RESET -> QK_BOOT (qmk#18365) Remove `RESET` keycodes from fjlabs keyboards (qmk#18364) [Keyboard] Add Vector PCB (qmk#17380) [Keyboard] Add Calice (qmk#17929) ...
tacahiroy
pushed a commit
to tacahiroy/qmk_firmware
that referenced
this pull request
Oct 2, 2022
by the spherical lad @an-achronism
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
by the spherical lad @an-achronism
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
by the spherical lad @an-achronism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial support for Tetromino ortholinear keyboard added; was advised to keep default keymap.c spartan, so made separate keymap with custom RGB indicator behaviour as a compromise. If this is something that can be included in default instead, I would prefer to do so.
Types of Changes
Issues Fixed or Closed by This PR
Checklist