Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added gmmk v2 p65 keyboard. #18185

Merged
merged 7 commits into from
Sep 9, 2022
Merged

Added gmmk v2 p65 keyboard. #18185

merged 7 commits into from
Sep 9, 2022

Conversation

itarze
Copy link
Contributor

@itarze itarze commented Aug 28, 2022

Description

Assist Glorious to add a GMMK V2 65% keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 28, 2022
@itarze itarze requested a review from drashna August 29, 2022 01:11
@drashna drashna requested a review from a team August 29, 2022 04:35
@itarze itarze mentioned this pull request Aug 29, 2022
Merged
14 tasks
@guilleortas
Copy link

guilleortas commented Aug 29, 2022 •
edited
Loading

Hi @itarze, I have a couple of questions. Why changing the EEPROM driver from custom (see rules.mk from Glorious' fork) to wear_leveling?
Also, do you know what's the maximum size of the bin? I'm planning to build VIAL for the GMMK 2 65%, which might require more space.

@itarze
Copy link
Contributor Author

itarze commented Aug 29, 2022 •
edited
Loading

used/total: 44k/256k @guilleortas
Because the latest QMK firmware does not require the Custom method to implement the EEPROM driver.

@guilleortas
Copy link

guilleortas commented Aug 29, 2022 •
edited
Loading

@itarze great news, thanks. I'll try it out as soon as my GMMK2 arrives, should be tomorrow.
I was checking the datasheet of the WB32F3G71XX and it says the flash size is 128kB rather than 256kB and I'm guessing not all of it will be available to QMK. Any ideas?

@itarze
Copy link
Contributor Author

itarze commented Aug 29, 2022

WB32F3G71xC is 256k. @guilleortas

@guilleortas
Copy link

@itarze I have tested your branch and everything works beautifully on my GMMK 2 65% ISO, except that for some reason VIA doesn't pick it up, even with the appropriate design file (I made it myself). VIAL GUI has the same issue and shows as GMMK Pro, sideloading the VIA design file has no effect.
Am I missing something? Could you provide the correct json design file for VIA?
Thanks you!

@itarze
Copy link
Contributor Author

itarze commented Aug 31, 2022 •
edited
Loading

gmmk_v2_p65.zip
@guilleortas You try it.

@guilleortas
Copy link

guilleortas commented Aug 31, 2022 •
edited
Loading

@itarze Perfect, it worked great! Thank you for the swift reply.
I'm looking at the differences between our design files and other than the underglow effects I'm still not seeing why mine didn't work...
Just one more question, are you familiar with VIAL? I'm able to compile and flash VIAL based on your work and everything works great in the GUI configurator and all the features are picked up just fine, however the RGB is not working. Any ideas?

@itarze
Copy link
Contributor Author

itarze commented Aug 31, 2022 •
edited
Loading

Do you mean that the current branch compiles the firmware, RGB does not work? @guilleortas
You can use the RGB_Toggle key to see if RGB is turned off.
I'm not familiar with VIAL yet.

@guilleortas
Copy link

@itarze No, this PR works great for me (RGB included) now that your design file solved the VIA issue.
What I meant is that using this as a base, I ported the GMMK 2 to VIAL, and VIAL works fine, except that RGB doesn't work (I have made sure it wasn't just off).

@luizkowalski
Copy link

hey @itarze
first of all, SOLID WORK on this one. I just compiled this firmware (for via) on mac and it worked perfectly! I can't believe it, really, awesome work dude
second, I have a couple of questions:

  1. the VIA config file you posted has a typo

image

  1. any chance you could remember the name of the underglow effect that "explodes" when you press a key? this one was present on the default firmware but not on the VIA config file you've attached

@luizkowalski
Copy link

I also noticed something weird (on mac, at least)
When I lock the screen, the keyboard "shuts down" after a minute or so after inactivity (RGB goes off)
when I press any button, the lights turn back on but the keyboard doesn't respond to any key press, I have to reconnect the cable. any idea what could be the problem?

@itarze
Copy link
Contributor Author

itarze commented Sep 2, 2022 •
edited
Loading

I also noticed something weird (on mac, at least) When I lock the screen, the keyboard "shuts down" after a minute or so after inactivity (RGB goes off) when I press any button, the lights turn back on but the keyboard doesn't respond to any key press, I have to reconnect the cable. any idea what could be the problem?

@luizkowalski Add this PR #18058 change to the firmware.

@itarze itarze changed the title Added gmmk v2 p5 keyboard. Added gmmk v2 p65 keyboard. Sep 2, 2022
@itarze
Copy link
Contributor Author

itarze commented Sep 2, 2022

hey @itarze first of all, SOLID WORK on this one. I just compiled this firmware (for via) on mac and it worked perfectly! I can't believe it, really, awesome work dude second, I have a couple of questions:

  1. the VIA config file you posted has a typo
image
  1. any chance you could remember the name of the underglow effect that "explodes" when you press a key? this one was present on the default firmware but not on the VIA config file you've attached
  1. Thank you very much for reminding me, I have corrected the typo.
  2. Could you please provide a video so that I can better find this effect?

@luizkowalski
Copy link

luizkowalski commented Sep 2, 2022 •
edited
Loading

  1. Could you please provide a video so that I can better find this effect?

yes., sure, it is this one: https://www.youtube.com/shorts/88_bw3COPhY

I managed to find it, simply by updating config.h and adding this

#define RGB_MATRIX_KEYPRESSES
#define RGB_MATRIX_FRAMEBUFFER_EFFECTS

then started to navigate through the effects with fn+right until I found it

I also copied the changes from that PR you mentioned and flashed it again, the issue is gone 🎉

@itarze
Copy link
Contributor Author

itarze commented Sep 2, 2022

@luizkowalski
Good, gmmk_v2_p65.json.
I have added all the RGB effects to VIA JSON.

#define RGB_MATRIX_KEYPRESSES
#define RGB_MATRIX_FRAMEBUFFER_EFFECTS

Define these two macros to enable full effects.

@luizkowalski
Copy link

Yeah, I added these definitions and flashed it yesterday, worked perfectly!
I think you could add these to the PR too

@zvecr zvecr merged commit 405a32d into qmk:master Sep 9, 2022
@itarze itarze deleted the gmmk2_p65 branch September 14, 2022 01:30
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
@itarze @tacahiroy
Added gmmk v2 p65 keyboard. (qmk#18185)
1c5a3d4
@adophoxia adophoxia mentioned this pull request Oct 10, 2022
Merged
6 tasks
SjB added a commit to SjB/qmk_firmware that referenced this pull request Oct 12, 2022
@SjB
Merge remote-tracking branch 'upstream/master' into sjb/all-keyboard
8def421 
* upstream/master: (319 commits)
  Fix handwired/swiftrax/bumblebee layout macro (qmk#18377)
  [Keyboard] Add pi40 (qmk#18207)
  [Keyboard] Removal of deprecated defines in IDOBAO keyboards (qmk#18358)
  Fix problem that Chidori is not recognized by host computer. (qmk#17882)
  [Keyboard] Add a new keyboard 'plum47' (qmk#18359)
  [Docs] RESET -> QK_BOOT (qmk#18365)
  Remove `RESET` keycodes from fjlabs keyboards (qmk#18364)
  [Keyboard] Add Vector PCB (qmk#17380)
  [Keyboard] Add Calice (qmk#17929)
  GeonWorks Frog Mini Soldered Layout Rework (qmk#18308)
  [Keyboard] Add skmt/15k keyboard (qmk#18321)
  [Keyboard] Replace Nayeon ATmega32u4 config with RP2040 (qmk#18265)
  Bump anothrNick/github-tag-action from 1.42.0 to 1.45.0 (qmk#18355)
  fix: Remove TERM_ON/TERM_OFF from my keymap (qmk#18354)
  Bump anothrNick/github-tag-action from 1.39.0 to 1.42.0 (qmk#18344)
  Fix keyboard_name for Unicomp Classic/Ultra Classic keyboards (qmk#18327)
  Add EM.8 keyboard  (qmk#18328)
  fixed missing x coordinate on spacebar (qmk#18330)
  GMMK2: Fix 'ISO' within product name (qmk#18322)
  Added gmmk v2 p65 keyboard. (qmk#18185)
  ...
@adophoxia adophoxia mentioned this pull request Oct 29, 2022
Merged
6 tasks
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@itarze @ramonimbao
Added gmmk v2 p65 keyboard. (qmk#18185)
54c5f5b
@Thoxy67 Thoxy67 mentioned this pull request Dec 6, 2022
Closed
6 tasks
@adophoxia adophoxia mentioned this pull request Dec 29, 2022
Merged
6 tasks
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@itarze @nolanseaton
Added gmmk v2 p65 keyboard. (qmk#18185)
d46b5e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@itarze @guilleortas @luizkowalski @drashna @zvecr