Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gmmk2 p65/p96 iso and ansi v3 json config #1553

Closed
wants to merge 1 commit into from
Closed

Add gmmk2 p65/p96 iso and ansi v3 json config #1553

wants to merge 1 commit into from

Conversation

Thoxy67
Copy link

@Thoxy67 Thoxy67 commented Dec 6, 2022

Description

I have exported and modified the gmmk2 json config (v2) to match the new v3 config.
This actually tested on my gmmk2 iso latest qmk firmware with via enabled and work like a charm. I suppose the config must not be different on the other editions

QMK Pull Request

qmk/qmk_firmware#16436 (p96)
qmk/qmk_firmware#18185 (p65)

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@yiancar
Copy link
Collaborator

yiancar commented Dec 20, 2022

hello, there is conflicts, please resolve them.
also note we auto converted a lot of the v2 files to v3 so this might be redundunt.

@yiancar
Copy link
Collaborator

yiancar commented Jan 26, 2023

Hello I will be closing this as it has been a while. If you decide to fix it please ping me to open it up again.

@yiancar yiancar closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants