Remove HD44780 References, Part 4 #10735

noroadsleft · 2020-10-23T09:57:27Z

Description

Removes references to the HD44780 LCD Display from config.h and rules.mk files.

There aren't any keyboards in the tree that use this feature, so its configuration and rules settings are basically bloat.

This doesn't remove the feature from QMK.

Part 4 of a series. Covers keyboards starting with I-M (plus evyd13's keyboards, which were moved in another PR).

Types of Changes

Enhancement/optimization
Keyboard (addition or update)

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
I have read the CONTRIBUTING document.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr

Changes look good, however there are 5 user keymaps that got changed. Breaking changes or i guess back them out to still target master?

noroadsleft · 2020-10-24T19:35:46Z

Part 1 and Part 3 both had edits to user keymaps and were merged to the master branch. (I started this task so long ago that I actually don't remember if I meant to include keymap-level changes.) I can back out the keymap changes if you'd feel better about that.

noroadsleft · 2020-10-25T21:57:57Z

After thinking about this over the last day, I decided I'd rather excise this bloat from the codebase as best as possible, so I'm going to retarget this to the develop branch, including the parts I had planned for future pull requests.

* Branch point for 2020 November 28 Breaking Change * Remove matrix_col_t to allow MATRIX_ROWS > 32 (#10183) * Add support for soft serial to ATmega32U2 (#10204) * Change MIDI velocity implementation to allow direct control of velocity value (#9940) * Add ability to build a subset of all keyboards based on platform. * Actually use eeprom_driver_init(). * Make bootloader_jump weak for ChibiOS. (#10417) * Joystick 16-bit support (#10439) * Per-encoder resolutions (#10259) * Share button state from mousekey to pointing_device (#10179) * Add hotfix for chibios keyboards not wake (#10088) * Add advanced/efficient RGB Matrix Indicators (#8564) * Naming change. * Support for STM32 GPIOF,G,H,I,J,K (#10206) * Add milc as a dependency and remove the installed milc (#10563) * ChibiOS upgrade: early init conversions (#10214) * ChibiOS upgrade: configuration file migrator (#9952) * Haptic and solenoid cleanup (#9700) * XD75 cleanup (#10524) * OLED display update interval support (#10388) * Add definition based on currently-selected serial driver. (#10716) * New feature: Retro Tapping per key (#10622) * Allow for modification of output RGB values when using rgblight/rgb_matrix. (#10638) * Add housekeeping task callbacks so that keyboards/keymaps are capable of executing code for each main loop iteration. (#10530) * Rescale both ChibiOS and AVR backlighting. * Reduce Helix keyboard build variation (#8669) * Minor change to behavior allowing display updates to continue between task ticks (#10750) * Some GPIO manipulations in matrix.c change to atomic. (#10491) * qmk cformat (#10767) * [Keyboard] Update the Speedo firmware for v3.0 (#10657) * Maartenwut/Maarten namechange to evyd13/Evy (#10274) * [quantum] combine repeated lines of code (#10837) * Add step sequencer feature (#9703) * aeboards/ext65 refactor (#10820) * Refactor xelus/dawn60 for Rev2 later (#10584) * add DEBUG_MATRIX_SCAN_RATE_ENABLE to common_features.mk (#10824) * [Core] Added `add_oneshot_mods` & `del_oneshot_mods` (#10549) * update chibios os usb for the otg driver (#8893) * Remove HD44780 References, Part 4 (#10735) * [Keyboard] Add Valor FRL TKL (+refactor) (#10512) * Fix cursor position bug in oled_write_raw functions (#10800) * Fixup version.h writing when using SKIP_VERSION=yes (#10972) * Allow for certain code in the codebase assuming length of string. (#10974) * Add AT90USB support for serial.c (#10706) * Auto shift: support repeats and early registration (#9826) * Rename ledmatrix.h to match .c file (#7949) * Split RGB_MATRIX_ENABLE into _ENABLE and _DRIVER (#10231) * Split LED_MATRIX_ENABLE into _ENABLE and _DRIVER (#10840) * Merge point for 2020 Nov 28 Breaking Change

* Branch point for 2020 November 28 Breaking Change * Remove matrix_col_t to allow MATRIX_ROWS > 32 (qmk#10183) * Add support for soft serial to ATmega32U2 (qmk#10204) * Change MIDI velocity implementation to allow direct control of velocity value (qmk#9940) * Add ability to build a subset of all keyboards based on platform. * Actually use eeprom_driver_init(). * Make bootloader_jump weak for ChibiOS. (qmk#10417) * Joystick 16-bit support (qmk#10439) * Per-encoder resolutions (qmk#10259) * Share button state from mousekey to pointing_device (qmk#10179) * Add hotfix for chibios keyboards not wake (qmk#10088) * Add advanced/efficient RGB Matrix Indicators (qmk#8564) * Naming change. * Support for STM32 GPIOF,G,H,I,J,K (qmk#10206) * Add milc as a dependency and remove the installed milc (qmk#10563) * ChibiOS upgrade: early init conversions (qmk#10214) * ChibiOS upgrade: configuration file migrator (qmk#9952) * Haptic and solenoid cleanup (qmk#9700) * XD75 cleanup (qmk#10524) * OLED display update interval support (qmk#10388) * Add definition based on currently-selected serial driver. (qmk#10716) * New feature: Retro Tapping per key (qmk#10622) * Allow for modification of output RGB values when using rgblight/rgb_matrix. (qmk#10638) * Add housekeeping task callbacks so that keyboards/keymaps are capable of executing code for each main loop iteration. (qmk#10530) * Rescale both ChibiOS and AVR backlighting. * Reduce Helix keyboard build variation (qmk#8669) * Minor change to behavior allowing display updates to continue between task ticks (qmk#10750) * Some GPIO manipulations in matrix.c change to atomic. (qmk#10491) * qmk cformat (qmk#10767) * [Keyboard] Update the Speedo firmware for v3.0 (qmk#10657) * Maartenwut/Maarten namechange to evyd13/Evy (qmk#10274) * [quantum] combine repeated lines of code (qmk#10837) * Add step sequencer feature (qmk#9703) * aeboards/ext65 refactor (qmk#10820) * Refactor xelus/dawn60 for Rev2 later (qmk#10584) * add DEBUG_MATRIX_SCAN_RATE_ENABLE to common_features.mk (qmk#10824) * [Core] Added `add_oneshot_mods` & `del_oneshot_mods` (qmk#10549) * update chibios os usb for the otg driver (qmk#8893) * Remove HD44780 References, Part 4 (qmk#10735) * [Keyboard] Add Valor FRL TKL (+refactor) (qmk#10512) * Fix cursor position bug in oled_write_raw functions (qmk#10800) * Fixup version.h writing when using SKIP_VERSION=yes (qmk#10972) * Allow for certain code in the codebase assuming length of string. (qmk#10974) * Add AT90USB support for serial.c (qmk#10706) * Auto shift: support repeats and early registration (qmk#9826) * Rename ledmatrix.h to match .c file (qmk#7949) * Split RGB_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10231) * Split LED_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10840) * Merge point for 2020 Nov 28 Breaking Change

noroadsleft added enhancement keyboard labels Oct 23, 2020

noroadsleft requested a review from a team October 23, 2020 09:57

github-actions bot added the keymap label Oct 23, 2020

fauxpark approved these changes Oct 23, 2020

View reviewed changes

noroadsleft added optimization and removed enhancement labels Oct 23, 2020

zvecr reviewed Oct 23, 2020

View reviewed changes

noroadsleft changed the base branch from master to develop October 25, 2020 21:59

noroadsleft force-pushed the clean/hd44780-4 branch from c3169ad to ca96d6a Compare October 25, 2020 22:01

skullydazed force-pushed the develop branch from db745a9 to 68fc044 Compare October 28, 2020 02:16

noroadsleft force-pushed the develop branch from 92ca6b9 to c3221d4 Compare October 30, 2020 20:23

noroadsleft force-pushed the clean/hd44780-4 branch from ca96d6a to c623766 Compare October 30, 2020 20:46

noroadsleft requested a review from zvecr October 30, 2020 20:47

noroadsleft added 6 commits November 1, 2020 18:52

remove HD44780_ENABLE rules: I-M

d7cd93f

remove HD44780_ENABLE config: I-M

e03a4c8

remove HD44780_ENABLE rules: N-S

d0ba690

remove HD44780_ENABLE config: N-S

f0b575b

remove HD44780_ENABLE rules: T-Z

dfb9c21

remove HD44780_ENABLE config: T-Z

81657b6

noroadsleft force-pushed the clean/hd44780-4 branch from c623766 to 81657b6 Compare November 2, 2020 02:53

Erovia approved these changes Nov 15, 2020

View reviewed changes

zvecr approved these changes Nov 15, 2020

View reviewed changes

noroadsleft merged commit e3a2407 into qmk:develop Nov 15, 2020

noroadsleft deleted the clean/hd44780-4 branch November 15, 2020 16:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove HD44780 References, Part 4 #10735

Remove HD44780 References, Part 4 #10735

noroadsleft commented Oct 23, 2020 •

edited

Loading

zvecr left a comment

noroadsleft commented Oct 24, 2020

noroadsleft commented Oct 25, 2020 •

edited

Loading

Remove HD44780 References, Part 4 #10735

Remove HD44780 References, Part 4 #10735

Conversation

noroadsleft commented Oct 23, 2020 • edited Loading

Description

Types of Changes

Checklist

zvecr left a comment

Choose a reason for hiding this comment

noroadsleft commented Oct 24, 2020

noroadsleft commented Oct 25, 2020 • edited Loading

noroadsleft commented Oct 23, 2020 •

edited

Loading

noroadsleft commented Oct 25, 2020 •

edited

Loading