Support for STM32 GPIOF,G,H,I,J,K #10206

tzarc · 2020-08-31T01:37:47Z

Description

Adds support for GPIOF,G,H,I,J,K on STM32 devices, to match newer board definitions in ChibiOS 20.x.

-------------------------------
Successful builds: 1068
Warning builds: 42
Failing builds: 0
-------------------------------

Types of Changes

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark · 2020-08-31T02:27:22Z

quantum/config_common.h

+#        define K10 PAL_LINE(GPIOK, 10)
+#        define K11 PAL_LINE(GPIOK, 11)
+#        define K12 PAL_LINE(GPIOK, 12)
+#        define K13 PAL_LINE(GPIOK, 13)
+#        define K14 PAL_LINE(GPIOK, 14)
+#        define K15 PAL_LINE(GPIOK, 15)


These might be a problem, unless we standardise on kXX for layout macros.

Ohhh, good point. Hmmmm.

I'll mark this PR as a draft while we discuss.

well, don't we usually recommend/enforce lowercase for the matrix? If not, it may be worth doing so.
Also, good thing it doesn't hit L, because a bunch of splits use L##.

I'm not sure I want to count on users remembering to stick to lowercase for layout macros. I'd prefer to change the letter or the notation system.

That's a good point. Though, in theory, it should error out when trying to compile?

Otherwise, I vote for q.

I like the idea of using q; in spite of how common the letter Q is around the project, it's unlikely to be used or needed anywhere else.

Added a guard around the GPIOK definitions -- #define KEYBOARD_REQUIRES_GPIOK -- which opts-in to defining them.

…rder to gain access.

* Add GPIOF/GPIOH. * Also add GPIOI,GPIOJ,GPIOK, to match ChibiOS 20.x. * Make GPIOK opt-in, describe what a keyboard designer needs to do in order to gain access.

* Branch point for 2020 November 28 Breaking Change * Remove matrix_col_t to allow MATRIX_ROWS > 32 (#10183) * Add support for soft serial to ATmega32U2 (#10204) * Change MIDI velocity implementation to allow direct control of velocity value (#9940) * Add ability to build a subset of all keyboards based on platform. * Actually use eeprom_driver_init(). * Make bootloader_jump weak for ChibiOS. (#10417) * Joystick 16-bit support (#10439) * Per-encoder resolutions (#10259) * Share button state from mousekey to pointing_device (#10179) * Add hotfix for chibios keyboards not wake (#10088) * Add advanced/efficient RGB Matrix Indicators (#8564) * Naming change. * Support for STM32 GPIOF,G,H,I,J,K (#10206) * Add milc as a dependency and remove the installed milc (#10563) * ChibiOS upgrade: early init conversions (#10214) * ChibiOS upgrade: configuration file migrator (#9952) * Haptic and solenoid cleanup (#9700) * XD75 cleanup (#10524) * OLED display update interval support (#10388) * Add definition based on currently-selected serial driver. (#10716) * New feature: Retro Tapping per key (#10622) * Allow for modification of output RGB values when using rgblight/rgb_matrix. (#10638) * Add housekeeping task callbacks so that keyboards/keymaps are capable of executing code for each main loop iteration. (#10530) * Rescale both ChibiOS and AVR backlighting. * Reduce Helix keyboard build variation (#8669) * Minor change to behavior allowing display updates to continue between task ticks (#10750) * Some GPIO manipulations in matrix.c change to atomic. (#10491) * qmk cformat (#10767) * [Keyboard] Update the Speedo firmware for v3.0 (#10657) * Maartenwut/Maarten namechange to evyd13/Evy (#10274) * [quantum] combine repeated lines of code (#10837) * Add step sequencer feature (#9703) * aeboards/ext65 refactor (#10820) * Refactor xelus/dawn60 for Rev2 later (#10584) * add DEBUG_MATRIX_SCAN_RATE_ENABLE to common_features.mk (#10824) * [Core] Added `add_oneshot_mods` & `del_oneshot_mods` (#10549) * update chibios os usb for the otg driver (#8893) * Remove HD44780 References, Part 4 (#10735) * [Keyboard] Add Valor FRL TKL (+refactor) (#10512) * Fix cursor position bug in oled_write_raw functions (#10800) * Fixup version.h writing when using SKIP_VERSION=yes (#10972) * Allow for certain code in the codebase assuming length of string. (#10974) * Add AT90USB support for serial.c (#10706) * Auto shift: support repeats and early registration (#9826) * Rename ledmatrix.h to match .c file (#7949) * Split RGB_MATRIX_ENABLE into _ENABLE and _DRIVER (#10231) * Split LED_MATRIX_ENABLE into _ENABLE and _DRIVER (#10840) * Merge point for 2020 Nov 28 Breaking Change

* Branch point for 2020 November 28 Breaking Change * Remove matrix_col_t to allow MATRIX_ROWS > 32 (qmk#10183) * Add support for soft serial to ATmega32U2 (qmk#10204) * Change MIDI velocity implementation to allow direct control of velocity value (qmk#9940) * Add ability to build a subset of all keyboards based on platform. * Actually use eeprom_driver_init(). * Make bootloader_jump weak for ChibiOS. (qmk#10417) * Joystick 16-bit support (qmk#10439) * Per-encoder resolutions (qmk#10259) * Share button state from mousekey to pointing_device (qmk#10179) * Add hotfix for chibios keyboards not wake (qmk#10088) * Add advanced/efficient RGB Matrix Indicators (qmk#8564) * Naming change. * Support for STM32 GPIOF,G,H,I,J,K (qmk#10206) * Add milc as a dependency and remove the installed milc (qmk#10563) * ChibiOS upgrade: early init conversions (qmk#10214) * ChibiOS upgrade: configuration file migrator (qmk#9952) * Haptic and solenoid cleanup (qmk#9700) * XD75 cleanup (qmk#10524) * OLED display update interval support (qmk#10388) * Add definition based on currently-selected serial driver. (qmk#10716) * New feature: Retro Tapping per key (qmk#10622) * Allow for modification of output RGB values when using rgblight/rgb_matrix. (qmk#10638) * Add housekeeping task callbacks so that keyboards/keymaps are capable of executing code for each main loop iteration. (qmk#10530) * Rescale both ChibiOS and AVR backlighting. * Reduce Helix keyboard build variation (qmk#8669) * Minor change to behavior allowing display updates to continue between task ticks (qmk#10750) * Some GPIO manipulations in matrix.c change to atomic. (qmk#10491) * qmk cformat (qmk#10767) * [Keyboard] Update the Speedo firmware for v3.0 (qmk#10657) * Maartenwut/Maarten namechange to evyd13/Evy (qmk#10274) * [quantum] combine repeated lines of code (qmk#10837) * Add step sequencer feature (qmk#9703) * aeboards/ext65 refactor (qmk#10820) * Refactor xelus/dawn60 for Rev2 later (qmk#10584) * add DEBUG_MATRIX_SCAN_RATE_ENABLE to common_features.mk (qmk#10824) * [Core] Added `add_oneshot_mods` & `del_oneshot_mods` (qmk#10549) * update chibios os usb for the otg driver (qmk#8893) * Remove HD44780 References, Part 4 (qmk#10735) * [Keyboard] Add Valor FRL TKL (+refactor) (qmk#10512) * Fix cursor position bug in oled_write_raw functions (qmk#10800) * Fixup version.h writing when using SKIP_VERSION=yes (qmk#10972) * Allow for certain code in the codebase assuming length of string. (qmk#10974) * Add AT90USB support for serial.c (qmk#10706) * Auto shift: support repeats and early registration (qmk#9826) * Rename ledmatrix.h to match .c file (qmk#7949) * Split RGB_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10231) * Split LED_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10840) * Merge point for 2020 Nov 28 Breaking Change

* Add GPIOF/GPIOH. * Also add GPIOI,GPIOJ,GPIOK, to match ChibiOS 20.x. * Make GPIOK opt-in, describe what a keyboard designer needs to do in order to gain access.

tzarc added enhancement core labels Aug 31, 2020

tzarc requested a review from a team August 31, 2020 01:37

tzarc changed the base branch from master to develop August 31, 2020 01:38

tzarc changed the title ~~Stm32 gpio ports g h~~ Support for STM32 GPIOF + GPIOH Aug 31, 2020

tzarc changed the title ~~Support for STM32 GPIOF + GPIOH~~ Support for STM32 GPIOF,G,H,I,J,K Aug 31, 2020

fauxpark reviewed Aug 31, 2020

View reviewed changes

tzarc marked this pull request as draft August 31, 2020 02:38

tzarc requested a review from a team August 31, 2020 02:38

noroadsleft force-pushed the develop branch from 3a8e1b8 to a1b96ba Compare September 4, 2020 22:03

noroadsleft force-pushed the develop branch from a1b96ba to 3430907 Compare September 12, 2020 11:46

drashna approved these changes Sep 20, 2020

View reviewed changes

tzarc added 3 commits October 5, 2020 11:21

Add GPIOF/GPIOH.

7d2370c

Also add GPIOI,GPIOJ,GPIOK, to match ChibiOS 20.x.

66462e8

Make GPIOK opt-in, describe what a keyboard designer needs to do in o…

bfcb501

…rder to gain access.

tzarc force-pushed the stm32-gpio-ports-g-h branch from 3179c82 to bfcb501 Compare October 5, 2020 00:22

tzarc marked this pull request as ready for review October 5, 2020 03:07

tzarc requested a review from a team October 5, 2020 03:07

nooges approved these changes Oct 5, 2020

View reviewed changes

tzarc merged commit f282569 into qmk:develop Oct 5, 2020

skullydazed pushed a commit that referenced this pull request Oct 18, 2020

Support for STM32 GPIOF,G,H,I,J,K (#10206)

1cf9216

* Add GPIOF/GPIOH. * Also add GPIOI,GPIOJ,GPIOK, to match ChibiOS 20.x. * Make GPIOK opt-in, describe what a keyboard designer needs to do in order to gain access.

noroadsleft pushed a commit that referenced this pull request Oct 23, 2020

Support for STM32 GPIOF,G,H,I,J,K (#10206)

df42a10

* Add GPIOF/GPIOH. * Also add GPIOI,GPIOJ,GPIOK, to match ChibiOS 20.x. * Make GPIOK opt-in, describe what a keyboard designer needs to do in order to gain access.

skullydazed pushed a commit that referenced this pull request Oct 28, 2020

Support for STM32 GPIOF,G,H,I,J,K (#10206)

9e316dd

* Add GPIOF/GPIOH. * Also add GPIOI,GPIOJ,GPIOK, to match ChibiOS 20.x. * Make GPIOK opt-in, describe what a keyboard designer needs to do in order to gain access.

noroadsleft pushed a commit that referenced this pull request Oct 30, 2020

Support for STM32 GPIOF,G,H,I,J,K (#10206)

53f2b5b

* Add GPIOF/GPIOH. * Also add GPIOI,GPIOJ,GPIOK, to match ChibiOS 20.x. * Make GPIOK opt-in, describe what a keyboard designer needs to do in order to gain access.

tzarc deleted the stm32-gpio-ports-g-h branch March 2, 2021 05:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for STM32 GPIOF,G,H,I,J,K #10206

Support for STM32 GPIOF,G,H,I,J,K #10206

tzarc commented Aug 31, 2020 •

edited

Loading

fauxpark Aug 31, 2020

tzarc Aug 31, 2020

tzarc Aug 31, 2020

drashna Sep 6, 2020

noroadsleft Sep 8, 2020

drashna Sep 9, 2020

noroadsleft Sep 10, 2020

tzarc Sep 10, 2020

tzarc Oct 5, 2020

Support for STM32 GPIOF,G,H,I,J,K #10206

Support for STM32 GPIOF,G,H,I,J,K #10206

Conversation

tzarc commented Aug 31, 2020 • edited Loading

Description

Types of Changes

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tzarc commented Aug 31, 2020 •

edited

Loading