Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the public PyUnicodeWriter API #125196

Closed
vstinner opened this issue Oct 9, 2024 · 2 comments
Closed

Use the public PyUnicodeWriter API #125196

vstinner opened this issue Oct 9, 2024 · 2 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-C-API topic-unicode

Comments

@vstinner
Copy link
Member

vstinner commented Oct 9, 2024 •
edited by bedevere-app bot
Loading

Replace PyUnicode_New(), PyUnicode_CopyCharacters(), etc. with PyUnicodeWriter. It avoids creating incomplete Unicode strings: see Avoid creating incomplete/invalid objects.

Linked PRs
vstinner added a commit to vstinner/cpython that referenced this issue Oct 9, 2024
@vstinner
pythongh-125196: Use PyUnicodeWriter in symtable.c
26a81a7
vstinner added a commit to vstinner/cpython that referenced this issue Oct 9, 2024
@vstinner
pythongh-125196: Use PyUnicodeWriter in symtable.c
7333a99
@bedevere-app bedevere-app bot mentioned this issue Oct 9, 2024
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Oct 9, 2024
@vstinner
pythongh-125196: Add PyUnicodeWriter_Fill() function
1feb88f
vstinner added a commit that referenced this issue Oct 9, 2024
@vstinner
gh-125196: Use PyUnicodeWriter in symtable.c (#125199)
9bda775
vstinner added a commit to vstinner/cpython that referenced this issue Oct 9, 2024
@vstinner
pythongh-125196: Add PyUnicodeWriter_Fill() function
cbc84c3
vstinner added a commit to vstinner/cpython that referenced this issue Oct 9, 2024
@vstinner
pythongh-125196: Add PyUnicodeWriter_Fill() function
a78c3c2
vstinner added a commit to vstinner/cpython that referenced this issue Oct 9, 2024
@vstinner
pythongh-125196: Add PyUnicodeWriter_Fill() function
a2ca774
@bedevere-app bedevere-app bot mentioned this issue Oct 9, 2024
Closed
@vstinner
Copy link
Member Author

vstinner commented Oct 9, 2024

I also replaced PyUnicode_New(0, 0) with Py_GetConstant(Py_CONSTANT_EMPTY_STR) in commit b9a8ca0.

vstinner added a commit to vstinner/cpython that referenced this issue Oct 9, 2024
@vstinner
pythongh-125196: Use PyUnicodeWriter for repr(list)
8c33f91 
Replace the private _PyUnicodeWriter with the public PyUnicodeWriter.
@bedevere-app bedevere-app bot mentioned this issue Oct 9, 2024
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Oct 9, 2024
@vstinner
pythongh-125196: Add fast-path for int in PyUnicodeWriter_WriteStr()
3400d0a 
PyUnicodeWriter_WriteStr() and PyUnicodeWriter_WriteRepr() now call
directly _PyLong_FormatWriter() if the object is an int.
@bedevere-app bedevere-app bot mentioned this issue Oct 9, 2024
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Oct 9, 2024
@vstinner
pythongh-125196: Use PyUnicodeWriter for repr(structseq)
220667c 
Replace the private _PyUnicodeWriter with the public PyUnicodeWriter.

* Avoid temporary PyUnicode_DecodeUTF8(): call
  PyUnicodeWriter_WriteUTF8() instead.
* Avoid temporary PyObject_Repr(): call PyUnicodeWriter_WriteRepr()
  instead.
@bedevere-app bedevere-app bot mentioned this issue Oct 9, 2024
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Oct 9, 2024
@vstinner
pythongh-125196: Use PyUnicodeWriter for repr(contextvars.Token)
5b7be71 
Replace the private _PyUnicodeWriter with the public PyUnicodeWriter.
@bedevere-app bedevere-app bot mentioned this issue Oct 9, 2024
Merged
vstinner added a commit that referenced this issue Oct 9, 2024
@vstinner
gh-125196: Use PyUnicodeWriter for repr(list) (#125202)
52f70da 
Replace the private _PyUnicodeWriter with the public PyUnicodeWriter.

Replace PyObject_Repr() + _PyUnicodeWriter_WriteStr()
with PyUnicodeWriter_WriteRepr().
vstinner added a commit to vstinner/cpython that referenced this issue Oct 9, 2024
@vstinner
pythongh-125196: PyUnicodeWriter_Discard(NULL) does nothing
5e51ebf
@bedevere-app bedevere-app bot mentioned this issue Oct 9, 2024
Merged
vstinner added a commit that referenced this issue Oct 9, 2024
@vstinner
gh-125196: Add fast-path for int in PyUnicodeWriter_WriteStr() (#125214)
ee3167b 
PyUnicodeWriter_WriteStr() and PyUnicodeWriter_WriteRepr() now call
directly _PyLong_FormatWriter() if the argument is an int.
vstinner added a commit that referenced this issue Oct 9, 2024
@vstinner
gh-125196: Use PyUnicodeWriter for repr(structseq) (#125219)
1877543 
Replace the private _PyUnicodeWriter with the public PyUnicodeWriter.

* Avoid temporary PyUnicode_DecodeUTF8(): call
  PyUnicodeWriter_WriteUTF8() instead.
* Avoid temporary PyObject_Repr(): call PyUnicodeWriter_WriteRepr()
  instead.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 9, 2024
@vstinner
pythongh-125196: Add a free list to PyUnicodeWriter
e4ab21f
@bedevere-app bedevere-app bot mentioned this issue Oct 9, 2024
Merged
vstinner added a commit that referenced this issue Oct 9, 2024
@vstinner
gh-125196: PyUnicodeWriter_Discard(NULL) does nothing (#125222)
1b2a548
vstinner added a commit that referenced this issue Oct 9, 2024
@vstinner
gh-125196: Use PyUnicodeWriter for repr(contextvars.Token) (#125220)
9429163 
Replace the private _PyUnicodeWriter with the public PyUnicodeWriter.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 10, 2024
@vstinner
pythongh-125196: Use PyUnicodeWriter for repr(tuple)
ce55e99
@bedevere-app bedevere-app bot mentioned this issue Oct 10, 2024
Merged
vstinner added a commit that referenced this issue Oct 10, 2024
@vstinner
gh-125196: Add a free list to PyUnicodeWriter (#125227)
1639d93
vstinner added a commit that referenced this issue Oct 10, 2024
@vstinner
gh-125196: Use PyUnicodeWriter for repr(tuple) (#125242)
82dfdc3
vstinner added a commit to vstinner/cpython that referenced this issue Oct 10, 2024
@vstinner
pythongh-125196: Use PyUnicodeWriter for JSON encoder
8f956aa 
Replace the private _PyUnicodeWriter with the public PyUnicodeWriter.
@bedevere-app bedevere-app bot mentioned this issue Oct 10, 2024
Merged
@encukou
Copy link
Member

encukou commented Oct 10, 2024

There's also a behaviour change: #125222 -- PyUnicodeWriter_Discard(NULL) does nothing

vstinner added a commit that referenced this issue Oct 10, 2024
@vstinner
gh-125196: Use PyUnicodeWriter for JSON encoder (#125249)
c914212 
Replace the private _PyUnicodeWriter with the public PyUnicodeWriter.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 10, 2024
@vstinner
pythongh-125196: Use PyUnicodeWriter in codecs
9223adf 
PyCodec_ReplaceErrors() and PyCodec_BackslashReplaceErrors() now use
the public PyUnicodeWriter API.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 10, 2024
@vstinner
pythongh-125196: Use PyUnicodeWriter in error handlers
e07ceda 
PyCodec_ReplaceErrors() and PyCodec_BackslashReplaceErrors() now use
the public PyUnicodeWriter API.
@bedevere-app bedevere-app bot mentioned this issue Oct 10, 2024
Closed
vstinner added a commit to vstinner/cpython that referenced this issue Oct 10, 2024
@vstinner
pythongh-125196: Use PyUnicodeWriter for repr(dict)
9f4379a
vstinner added a commit to vstinner/cpython that referenced this issue Oct 10, 2024
@vstinner
pythongh-125196: Use PyUnicodeWriter for repr(dict)
36b8dbd
@bedevere-app bedevere-app bot mentioned this issue Oct 10, 2024
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Oct 10, 2024
@vstinner
pythongh-125196: Use PyUnicodeWriter in parser
c335dc0 
Replace the private _PyUnicodeWriter API with the public
PyUnicodeWriter API in _PyPegen_concatenate_strings().
@bedevere-app bedevere-app bot mentioned this issue Oct 10, 2024
Merged
@vstinner vstinner changed the title Use PyUnicodeWriter API Use the public PyUnicodeWriter API Oct 10, 2024
vstinner added a commit that referenced this issue Oct 10, 2024
@vstinner
gh-125196: Use PyUnicodeWriter for repr(dict) (#125270)
bb594e8
@JacobCoffee JacobCoffee added topic-unicode interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-C-API labels Oct 10, 2024
vstinner added a commit that referenced this issue Oct 12, 2024
@vstinner
gh-125196: Use PyUnicodeWriter in parser (#125271)
4a943c3 
Replace the private _PyUnicodeWriter API with the public
PyUnicodeWriter API in _PyPegen_concatenate_strings().
vstinner added a commit to vstinner/cpython that referenced this issue Oct 14, 2024
@vstinner
pythongh-125196: Use PyUnicodeWriter in HAMT
df1de4e 
Replace the private _PyUnicodeWriter API with the public
PyUnicodeWriter API in hamt.c.

Remove _hamt_dump_format(): replace it with PyUnicodeWriter_Format().

Use PyUnicodeWriter_WriteUTF8() to write just a newline character.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 14, 2024
@vstinner
pythongh-125196: Use PyUnicodeWriter in HAMT
8da0ca3 
Replace the private _PyUnicodeWriter API with the public
PyUnicodeWriter API in hamt.c.

Remove _hamt_dump_format(): replace it with PyUnicodeWriter_Format().

Use PyUnicodeWriter_WriteUTF8() to write just a newline character.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 14, 2024
@vstinner
pythongh-125196: Use PyUnicodeWriter in HAMT
974e343 
Replace the private _PyUnicodeWriter API with the public
PyUnicodeWriter API in hamt.c.

Remove _hamt_dump_format(): replace it with PyUnicodeWriter_Format().

Use PyUnicodeWriter_WriteUTF8() to write constant strings.
@bedevere-app bedevere-app bot mentioned this issue Oct 14, 2024
Merged
vstinner added a commit that referenced this issue Oct 15, 2024
@vstinner
gh-125196: Use PyUnicodeWriter in HAMT (#125458)
aa18fd5
vstinner added a commit to vstinner/cpython that referenced this issue Oct 15, 2024
@vstinner
pythongh-125196: Use PyUnicodeWriter in _io.StringIO
5e96bfb
@bedevere-app bedevere-app bot mentioned this issue Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-C-API topic-unicode
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vstinner @encukou @JacobCoffee