gh-125196: Use PyUnicodeWriter in HAMT #125458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the private _PyUnicodeWriter API with the public PyUnicodeWriter API in hamt.c. Remove _hamt_dump_format(): replace it with PyUnicodeWriter_Format(). Use PyUnicodeWriter_WriteUTF8() to write constant strings.
picnixz
reviewed
Oct 14, 2024
Co-authored-by: Bénédikt Tran <[email protected]>
1st1
approved these changes
Oct 14, 2024
|
You need to update the branch first. |
Right, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the private _PyUnicodeWriter API with the public PyUnicodeWriter API in hamt.c.
Remove _hamt_dump_format(): replace it with PyUnicodeWriter_Format().
Use PyUnicodeWriter_WriteUTF8() to write constant strings.