gh-125196: Use PyUnicodeWriter in parser #125271
Merged
+8
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the private _PyUnicodeWriter API with the public PyUnicodeWriter API in _PyPegen_concatenate_strings().
vstinner
commented
Oct 10, 2024
| if (concat_str == NULL) { | ||
| _PyUnicodeWriter_Dealloc(&writer); |
There was a problem hiding this comment.
The writer must not be used after _PyUnicodeWriter_Finish().
pablogsal
reviewed
Oct 11, 2024
| @@ -1635,14 +1634,17 @@ _PyPegen_concatenate_strings(Parser *p, asdl_expr_seq *strings, | |||
| "abc" u"abc" -> "abcabc" */ | |||
| PyObject *kind = elem->v.Constant.kind; | |||
|
|
|||
| _PyUnicodeWriter_Init(&writer); | |||
| PyUnicodeWriter *writer = PyUnicodeWriter_Create(0); | |||
There was a problem hiding this comment.
IIRC that's the number of pre-allocated characters. If you know that you will need N characters, I think it's better to put N in advance so that you don't have to resize the buffer. Otherwise, 0 is a good choice if you don't know in advance how many characters you'll eventually need (at the cost of resizes).
|
Merged, thanks for the review @pablogsal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the private _PyUnicodeWriter API with the public PyUnicodeWriter API in _PyPegen_concatenate_strings().