Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_queue times out #115258

Closed
Eclips4 opened this issue Feb 10, 2024 · 17 comments
Closed

test_queue times out #115258

Eclips4 opened this issue Feb 10, 2024 · 17 comments
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@Eclips4
Copy link
Member

Eclips4 commented Feb 10, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

See https://github.com/python/cpython/actions/runs/7856342409/job/21439020143?pr=115257 for more details.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs
@Eclips4 Eclips4 added type-bug An unexpected behavior, bug, or error OS-windows tests Tests in the Lib/test dir labels Feb 10, 2024
@terryjreedy terryjreedy mentioned this issue Feb 10, 2024
Merged
@terryjreedy
Copy link
Member

This has blocked CI from passing for a least one PR, #115250 (now rerunning), but not for another, #115253.

@Eclips4 Eclips4 changed the title test_queue timed out on Windows free-threading build (x86) test_queue timed out on Windows free-threading build Feb 10, 2024
@Eclips4
Copy link
Member Author

Eclips4 commented Feb 10, 2024

This has blocked CI from passing for a least one PR, #115250 (now rerunning), but not for another, #115253.

Also seems this issue is not specific to x86, another one fail on x64: #115232

@Eclips4
Copy link
Member Author

Eclips4 commented Feb 10, 2024

Looks related to #104750

@terryjreedy
Copy link
Member

Since our workflow does not allow over-riding CI failure from unrelated test failures, I think test_queue.PyPriorityQueueTest.test_shutdown_all_methods_in_many_threads should be skipped until fixed.

@Eclips4 Eclips4 mentioned this issue Feb 10, 2024
Merged
@gvanrossum
Copy link
Member

Shall we just revert gh-104750? It seems I merged it prematurely, see #104750 (comment).

gvanrossum added a commit to gvanrossum/cpython that referenced this issue Feb 10, 2024
@gvanrossum
Revert "pythongh-96471: Add shutdown() method to queue.Queue (python#…
b431b87 
…104750)"

Reason for the revert: python#115258
test_queue timed out on Windows free-threading build.

The PR author had mentioned this in
python#104750 (comment)
but I forgot about it and merged anyway.

This reverts commit b2d9d13.
@gvanrossum gvanrossum mentioned this issue Feb 10, 2024
Closed
@gvanrossum
Copy link
Member

gvanrossum commented Feb 10, 2024 •
edited
Loading

If you want to just revert the offending PR, gh-115265 is a full revert (it's currently marinating in CI).

If someone wants to volunteer to create an alternative PR that just disables that test (ideally only when Windows and free-threading are detected) that would be even better.

colesbury added a commit to colesbury/cpython that referenced this issue Feb 11, 2024
@colesbury
pythongh-115258: Temporarily disable test on free-threaded Windows build
6eff26b 
The "test_shutdown_all_methods_in_many_threads" test times out on the Windows
free-threaded CI. This skips the test on that platform and configuration until
we figure out the root cause.
colesbury added a commit to colesbury/cpython that referenced this issue Feb 11, 2024
@colesbury
pythongh-115258: Temporarily disable test on free-threaded Windows build
807dfd4 
The "test_shutdown_all_methods_in_many_threads" test times out on the Windows
free-threaded CI. This skips the test on that platform and configuration until
we figure out the root cause.
@bedevere-app bedevere-app bot mentioned this issue Feb 11, 2024
Merged
@colesbury colesbury self-assigned this Feb 11, 2024
@colesbury
Copy link
Contributor

colesbury commented Feb 11, 2024 •
edited by gvanrossum
Loading

I'll look into this on Monday. Here's a PR that temporarily skips this test on the free-threaded WIndows build, if we prefer that over reverting the PR: #115269

@colesbury
Copy link
Contributor

It looks like the test also sometimes times out on the default Windows build. In this job it timed out after 10 minutes, was re-run, and then passed: https://github.com/python/cpython/actions/runs/7859086848/job/21444802020?pr=115269

@gvanrossum
Copy link
Member

It looks like the test also sometimes times out on the default Windows build. In this job it timed out after 10 minutes, was re-run, and then passed: https://github.com/python/cpython/actions/runs/7859086848/job/21444802020?pr=115269

Oh, then just skip these tests on Windows.

@gvanrossum gvanrossum changed the title test_queue timed out on Windows free-threading build test_queue timed out on Windows ~~free-threading~~ build Feb 11, 2024
@gvanrossum gvanrossum changed the title test_queue timed out on Windows ~~free-threading~~ build test_queue timed out on Windows build Feb 11, 2024
@gvanrossum gvanrossum changed the title test_queue timed out on Windows build test_queue times out on Windows build Feb 11, 2024
colesbury added a commit that referenced this issue Feb 11, 2024
@colesbury
gh-115258: Temporarily disable test on Windows (#115269)
1a6e213 
The "test_shutdown_all_methods_in_many_threads" test times out on the Windows CI.
This skips the test on Windows until we figure out the root cause.
@sobolevn sobolevn mentioned this issue Feb 11, 2024
Merged
@gvanrossum
Copy link
Member

I'll now commandeer this issue to track fixes to the offending tests. Hopefully @EpicWink has some ideas.

@itamaro
Copy link
Contributor

itamaro commented Feb 12, 2024

going to remove the free-threading label since the current theory is that this isn't free-threading specific.

@brandtbucher
Copy link
Member

We're seeing timeouts for test_queue on some AArch64 JIT builds too: https://github.com/python/cpython/actions/runs/7870838905?pr=115248

@gvanrossum
Copy link
Member

Okay, just disable those two tests for all platforms. (I'm not in a position to do it myself right now.)

@gvanrossum gvanrossum changed the title test_queue times out on Windows build test_queue times out Feb 12, 2024
Eclips4 added a commit to Eclips4/cpython that referenced this issue Feb 12, 2024
@Eclips4
pythongh-115258: Temporarily skip test on all platforms
7969043
@bedevere-app bedevere-app bot mentioned this issue Feb 12, 2024
Merged
@Eclips4
Copy link
Member Author

Eclips4 commented Feb 12, 2024

Okay, just disable those two tests for all platforms. (I'm not in a position to do it myself right now.)

Done in #115361

colesbury pushed a commit that referenced this issue Feb 12, 2024
@Eclips4
gh-115258: Temporarily skip some queue tests on all platforms (#115361
bee2a11 
)
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this issue Feb 14, 2024
@colesbury @fsc-eriker
pythongh-115258: Temporarily disable test on Windows (python#115269)
1f216d5 
The "test_shutdown_all_methods_in_many_threads" test times out on the Windows CI.
This skips the test on Windows until we figure out the root cause.
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this issue Feb 14, 2024
@Eclips4 @fsc-eriker
pythongh-115258: Temporarily skip some queue tests on all platforms (…
b3aa546 
…python#115361)
EpicWink added a commit to EpicWink/cpython that referenced this issue Feb 20, 2024
@EpicWink
WIP: fix threading queue shutdown all-methods-many-threads test (pyth…
71da36a 
…on#115258)
EpicWink added a commit to EpicWink/cpython that referenced this issue Feb 21, 2024
@EpicWink
WIP: fix threading queue shutdown all-methods-many-threads test (pyth…
57a8095 
…on#115258)
This was referenced Feb 25, 2024
Draft
Merged
@vstinner
Copy link
Member

What's the status? The tests are skipped for 1 month. If nobody knows how to fix it, I would like to suggest to revert the change which introduced the unstable tests.

@gvanrossum
Copy link
Member

What's the status? The tests are skipped for 1 month. If nobody knows how to fix it, I would like to suggest to revert the change which introduced the unstable tests.

Funny you should ask. There is a fix by the original authors (gh-115940), it just requires review and some validation. I don't want to rush things. Could you maybe review that PR?

gvanrossum pushed a commit that referenced this issue Mar 18, 2024
@YvesDup
gh-115258: Fix hanging tests for threading queue shutdown (#115940)
7707b14 
This reinstates `test_shutdown_immediate_all_methods_in_many_threads`
and improves `test_shutdown_all_methods_in_many_threads`.
@gvanrossum
Copy link
Member

The updated tests have been pushed.

vstinner pushed a commit to vstinner/cpython that referenced this issue Mar 20, 2024
@YvesDup @vstinner
pythongh-115258: Fix hanging tests for threading queue shutdown (pyth…
8e779c3 
…on#115940)

This reinstates `test_shutdown_immediate_all_methods_in_many_threads`
and improves `test_shutdown_all_methods_in_many_threads`.
adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
@YvesDup @adorilson
pythongh-115258: Fix hanging tests for threading queue shutdown (pyth…
3cbcb98 
…on#115940)

This reinstates `test_shutdown_immediate_all_methods_in_many_threads`
and improves `test_shutdown_all_methods_in_many_threads`.
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@YvesDup @diegorusso
pythongh-115258: Fix hanging tests for threading queue shutdown (pyth…
b577a43 
…on#115940)

This reinstates `test_shutdown_immediate_all_methods_in_many_threads`
and improves `test_shutdown_all_methods_in_many_threads`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@vstinner @itamaro @colesbury @gvanrossum @terryjreedy @brandtbucher @Eclips4