Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "gh-96471: Add shutdown() method to queue.Queue (#104750)" #115265

Closed
wants to merge 1 commit into from

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Feb 10, 2024

Reason for the revert: #115258 test_queue timed out on Windows free-threading build.

The PR author had mentioned this in
#104750 (comment) but I forgot about it and merged anyway.

This reverts commit b2d9d13.


📚 Documentation preview 📚: https://cpython-previews--115265.org.readthedocs.build/

…104750)"

Reason for the revert: python#115258
test_queue timed out on Windows free-threading build.

The PR author had mentioned this in
python#104750 (comment)
but I forgot about it and merged anyway.

This reverts commit b2d9d13.
@gvanrossum
Copy link
Member Author

@EpicWink Just letting you know your PR might be reverted. Don't worry, we can resubmit we disable the offending test. We may also be able to avoid reverting the whole PR by just disabling that test, if we're convinced the problem is restricted to the combination of free-threading, Windows, and that specific test.

@terryjreedy
Copy link
Member

terryjreedy commented Feb 11, 2024

After reviewing the added code, I suggest immediately reverting the failing test on Windows free-thread builds to stop interfering with good PRs, and monitor for other CI/buildbot failures, while investigating. I was thinking about debug prints but then saw the note on the original PR that they themselves cause failures.

EDIT: side note line 241: n_items is not used in this function as _qsize is re-called each loop.

@gvanrossum
Copy link
Member Author

gvanrossum commented Feb 11, 2024

Closing in favor of #115269 which disables the offending tests on Windows.

@gvanrossum gvanrossum closed this Feb 11, 2024
@gvanrossum gvanrossum deleted the revert-gh-104750 branch February 17, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants