Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-115258: Temporarily disable test on Windows #115269

Merged
merged 4 commits into from
Feb 11, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Feb 11, 2024

The "test_shutdown_all_methods_in_many_threads" test times out on the Windows CI. This skips the test on that platform until we figure out the root cause.

The "test_shutdown_all_methods_in_many_threads" test times out on the Windows
free-threaded CI. This skips the test on that platform and configuration until
we figure out the root cause.
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Are you comfortable merging this yourself?

@colesbury
Copy link
Contributor Author

I'll update the tests to just skip on Windows

@colesbury colesbury enabled auto-merge (squash) February 11, 2024 02:58
@colesbury colesbury changed the title gh-115258: Temporarily disable test on Windows free-threaded build gh-115258: Temporarily disable test on Windows Feb 11, 2024
@colesbury colesbury merged commit 1a6e213 into python:main Feb 11, 2024
30 checks passed
@colesbury colesbury deleted the gh-115258-skip branch February 11, 2024 03:26
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
The "test_shutdown_all_methods_in_many_threads" test times out on the Windows CI.
This skips the test on Windows until we figure out the root cause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants