Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-115252: Fix test_enum with -OO mode #115253

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 10, 2024

Now it passes with both modes.

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Feb 10, 2024
@ethanfurman ethanfurman merged commit 33f56b7 into python:main Feb 10, 2024
35 checks passed
@ethanfurman ethanfurman changed the title gh-115252: Fix test_enum with -00 mode gh-115252: Fix test_enum with -OO mode Feb 10, 2024
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Feb 10, 2024
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @sobolevn and @ethanfurman, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 33f56b743285f8419e92cfabe673fa165165a580 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2024
(cherry picked from commit 33f56b7)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 10, 2024

GH-115260 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Feb 10, 2024
ethanfurman pushed a commit that referenced this pull request Feb 11, 2024
)

(cherry picked from commit 33f56b7)

Co-authored-by: Nikita Sobolev <[email protected]>
sobolevn added a commit to sobolevn/cpython that referenced this pull request Feb 11, 2024
@bedevere-app
Copy link

bedevere-app bot commented Feb 11, 2024

GH-115279 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 11, 2024
sobolevn added a commit that referenced this pull request Feb 11, 2024
(cherry picked from commit 33f56b7)

Co-authored-by: Nikita Sobolev <[email protected]>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants