-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase Argument Clinic test coverage #106368
Labels
Comments
erlend-aasland
added
type-feature
A feature request or enhancement
topic-argument-clinic
labels
Jul 3, 2023
Also: a side effect of good coverage, is that it can help identify unreachable paths in the code. |
cc. @sobolevn, who I know enjoys increasing test coverage 📈 |
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this issue
Jul 3, 2023
Add tests for 'self' and 'defining_class' converter requirements.
erlend-aasland
added a commit
that referenced
this issue
Jul 3, 2023
Add tests for 'self' and 'defining_class' converter requirements.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jul 3, 2023
) Add tests for 'self' and 'defining_class' converter requirements. (cherry picked from commit 7f4c812) Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this issue
Jul 3, 2023
This was referenced Jul 3, 2023
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this issue
Jul 3, 2023
…n#106369) Add tests for 'self' and 'defining_class' converter requirements. (cherry picked from commit 7f4c812) Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland
added a commit
that referenced
this issue
Jul 3, 2023
…106370) Add tests for 'self' and 'defining_class' converter requirements. (cherry picked from commit 7f4c812) Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland
added a commit
that referenced
this issue
Jul 3, 2023
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this issue
Jul 3, 2023
(cherry picked from commit 3ee8dac) Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland
added a commit
that referenced
this issue
Jul 3, 2023
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this issue
Jul 3, 2023
(cherry picked from commit 3ee8dac) Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland
added a commit
that referenced
this issue
Jul 3, 2023
erlend-aasland
added a commit
that referenced
this issue
Jul 3, 2023
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this issue
Jul 3, 2023
Also assert parser error messages.
erlend-aasland
added a commit
that referenced
this issue
Jul 3, 2023
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jul 3, 2023
(cherry picked from commit 648688c) Co-authored-by: Erlend E. Aasland <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jul 3, 2023
(cherry picked from commit 648688c) Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this issue
Jul 3, 2023
Add: - test_disallowed_gropuing__no_matching_bracket - test_double_slash
Reopening to increase coverage for the DSL parser state machine and the docstring formatter. |
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this issue
Aug 3, 2023
Add tests for DSL parser state machine and docstring formatting
erlend-aasland
added a commit
that referenced
this issue
Aug 3, 2023
Add tests for DSL parser state machine and docstring formatting
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this issue
Aug 3, 2023
Add tests for directives and destinations
erlend-aasland
added a commit
that referenced
this issue
Aug 4, 2023
Add tests for directives and destinations
We're now at 93% coverage. |
AlexWaygood
added a commit
that referenced
this issue
Aug 4, 2023
AlexWaygood
added a commit
that referenced
this issue
Aug 6, 2023
kostyafarber
pushed a commit
to kostyafarber/cpython
that referenced
this issue
Aug 7, 2023
AlexWaygood
added a commit
that referenced
this issue
Aug 8, 2023
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this issue
Aug 15, 2023
…ustom C base name
erlend-aasland
added a commit
that referenced
this issue
Aug 15, 2023
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this issue
Aug 15, 2023
erlend-aasland
added a commit
that referenced
this issue
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Argument Clinic test suite consists of three parts:
ClinicExternalTest
)Test coverage is currently just above 80%, which is too low. I'd say we try to reach 90-something percent coverage.
Reminder: PRs for increased test coverage should be backported to all bugfix branches.
Linked PRs
ClinicExternalTests
fail #107364ClinicExternalTests
fail (GH-107364) #107365ClinicExternalTests
fail (GH-107364) #107366state_modulename_name
#107387expect_success()
fails #107606self.valid_line()
calls #107641The text was updated successfully, but these errors were encountered: